Remove YGExperimentalFeatureFixAbsoluteTrailingColumnMargin #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
…#1317) Summary: Pull Request resolved: facebook#1317 X-link: facebook/react-native#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: 9a7a23842335bffafa573c164a166b9ab8080160
NickGerleman
force-pushed
the
export-D45766764
branch
from
64ec233
to
1ec2b78
Compare
|
This pull request was exported from Phabricator. Differential Revision: D45766764 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 28, 2023
…#37374) Summary: X-link: facebook/yoga#1317 Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: cfa97bc2006815b0ae4393cdc0853967f54c3080
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Jun 29, 2023
…#37374) Summary: X-link: facebook/yoga#1317 Pull Request resolved: facebook#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: ee0a03469fde75298277e9553957e7436cedeacc
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Jun 29, 2023
Summary: X-link: facebook/yoga#1317 X-link: facebook/react-native#37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: b600b79b8436534fe48ef2acbfde8ba64068e593
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jun 29, 2023
Summary: X-link: facebook/yoga#1317 Pull Request resolved: #37374 This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one). Reviewed By: yungsters Differential Revision: D45766764 fbshipit-source-id: b600b79b8436534fe48ef2acbfde8ba64068e593
|
This pull request has been merged in 0aec0a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#37374
This is edge-casey enough, and I actually broke this in D42282358 without us noticing (I changed height to width of the bottom usage, instead, copy/pasting the value of the top one).
Reviewed By: yungsters
Differential Revision: D45766764