Remove YGNodeMarkDirtyAndPropagateToDescendants
#1448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D50963933 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
force-pushed
the
export-D50963933
branch
from
016f540 to
0e43f57
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50963933 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: Pull Request resolved: facebook#41305 X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933 fbshipit-source-id: 5d7b74c1c6c6318d4488715ee63fcf89f376bc85
|
This pull request was exported from Phabricator. Differential Revision: D50963933 |
NickGerleman
force-pushed
the
export-D50963933
branch
from
0e43f57 to
17fcb24
Compare
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41305 Pull Request resolved: facebook#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933 fbshipit-source-id: d788748d98248cde724d229a7730757879e9e306
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
force-pushed
the
export-D50963933
branch
from
17fcb24 to
0bc4618
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
|
This pull request was exported from Phabricator. Differential Revision: D50963933 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 4, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 4, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
force-pushed
the
export-D50963933
branch
from
0bc4618 to
4fd51e6
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
|
This pull request was exported from Phabricator. Differential Revision: D50963933 |
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
NickGerleman
added a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41305 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41305 X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933 fbshipit-source-id: 6482bd269928188b6469a358ffde5c4f9f5f9527
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 8, 2023
Summary: Pull Request resolved: #41305 X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933 fbshipit-source-id: 6482bd269928188b6469a358ffde5c4f9f5f9527
|
This pull request has been merged in 9eb8a62. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41305 X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933 fbshipit-source-id: 6482bd269928188b6469a358ffde5c4f9f5f9527
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: X-link: facebook/yoga#1448 This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable). Reviewed By: javache Differential Revision: D50963933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This should not be part of Yoga's API. If benchmarks want to do this, they still can (though I don't know the ones we have for it are super valuable).
Differential Revision: D50963933