Make trunk builds "0.0.0" #1466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Right now Yoga's main branch says it's 2.0.0, and RN's dirsync says its 1.14.0, but the code is really closer to what will be Yoga 3.0.0. This changes trunk builds to "0.0.0" for clarity, which will be assigned a real version number the first time publishing a new Yoga branch. This is separately a good practice to prevent the chance of accidental publishes causing damage. Differential Revision: D51236778
|
This pull request was exported from Phabricator. Differential Revision: D51236778 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 12, 2023
Summary: X-link: facebook/yoga#1466 Right now Yoga's main branch says it's 2.0.0, and RN's dirsync says its 1.14.0, but the code is really closer to what will be Yoga 3.0.0. This changes trunk builds to "0.0.0" for clarity, which will be assigned a real version number the first time publishing a new Yoga branch. This is separately a good practice to prevent the chance of accidental publishes causing damage. Changelog: [Internal] Differential Revision: D51236778
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/yoga#1466 Right now Yoga's main branch says it's 2.0.0, and RN's dirsync says its 1.14.0, but the code is really closer to what will be Yoga 3.0.0. This changes trunk builds to "0.0.0" for clarity, which will be assigned a real version number the first time publishing a new Yoga branch. This is separately a good practice to prevent the chance of accidental publishes causing damage. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D51236778
|
This pull request has been merged in bb892af. |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Pull Request resolved: #41423 X-link: facebook/yoga#1466 Right now Yoga's main branch says it's 2.0.0, and RN's dirsync says its 1.14.0, but the code is really closer to what will be Yoga 3.0.0. This changes trunk builds to "0.0.0" for clarity, which will be assigned a real version number the first time publishing a new Yoga branch. This is separately a good practice to prevent the chance of accidental publishes causing damage. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D51236778 fbshipit-source-id: 06cac89bcca1c707ce5c00f9c346f627eef6b4bc
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41423 X-link: facebook/yoga#1466 Right now Yoga's main branch says it's 2.0.0, and RN's dirsync says its 1.14.0, but the code is really closer to what will be Yoga 3.0.0. This changes trunk builds to "0.0.0" for clarity, which will be assigned a real version number the first time publishing a new Yoga branch. This is separately a good practice to prevent the chance of accidental publishes causing damage. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D51236778 fbshipit-source-id: 06cac89bcca1c707ce5c00f9c346f627eef6b4bc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Right now Yoga's main branch says it's 2.0.0, and RN's dirsync says its 1.14.0, but the code is really closer to what will be Yoga 3.0.0.
This changes trunk builds to "0.0.0" for clarity, which will be assigned a real version number the first time publishing a new Yoga branch.
This is separately a good practice to prevent the chance of accidental publishes causing damage.
Differential Revision: D51236778