Make position static behave like position static #1482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D51293606 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
|
This pull request was exported from Phabricator. Differential Revision: D51293606 |
joevilches
force-pushed
the
export-D51293606
branch
from
d14487b
to
975a0c1
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606 fbshipit-source-id: b90de742dae3c635ff8e30702073c87f0bd2e9a9
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
force-pushed
the
export-D51293606
branch
from
975a0c1
to
b7aec59
Compare
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
|
This pull request was exported from Phabricator. Differential Revision: D51293606 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: a24bac8df9faf7bee9787b7505babed3cae18e84
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 73e67f82401243bfcae7d8078882351013eb3550
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 4b77f26762c755b22b7024f93dc6f9607855770b
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1482 Pull Request resolved: facebook#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 5f689f3e96e5cc77af2a7bee0d9b0e83b3d95420
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 5, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 7a02f22a36a75f08a6f7968372db7b7933c3fc3e
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 21c7ae7edec1a08b09c7c948d4ef1ee412df23ab
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 1634e5963603360b351da9531f3bbe7bd814cf9b
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 4684055f44344f1608e615968b19e82dde7f39de
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: ff285316796d1db811d4dcfaf100c1cb73d4c463
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: aad97dc8ee797582b73544857fd398acaf488b11
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: bea02c6dd891e6be421c07de038755d455c54eff
…ng absolute node's position (facebook#1481) Summary: X-link: facebook/react-native#41684 Absolute nodes can be laid out by themselves and do not have to care about what is happening to their siblings. Because of this we can make `positionAbsoluteChild` the sole place where we handle this logic. Right now that is scattered around algorithm with many `if (child is absolute)` cases everywhere. This makes implementing position static a lot harder since we are relying on the CB to do all this work, not the parent. With this change the only time we set position for an absolute node and it matter (i.e. not overwritten) is in `positionAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51290723
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
force-pushed
the
export-D51293606
branch
from
d91f746
to
207aae1
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
|
This pull request was exported from Phabricator. Differential Revision: D51293606 |
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Dec 7, 2023
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: e09fe3951b5a70668ab700c1a11f872a143ea5dd
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: cb3174fe68a652732323881f619fb4e91ae7eb4e
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: 6837a5e6057f0bbce401f91c23989f5bc602800d
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Dec 7, 2023
Summary: Pull Request resolved: facebook#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Differential Revision: https://www.internalfb.com/diff/D51293606?entry_point=27 fbshipit-source-id: e4b0b46c984210c0c4b066046917aa67c63e7bce
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 8, 2023
Summary: X-link: facebook/yoga#1482 X-link: facebook/react-native#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606 fbshipit-source-id: 972259e7ebecb19b55aef2ef866bd7cb57aaf0ca
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Dec 8, 2023
Summary: X-link: facebook/yoga#1482 Pull Request resolved: #41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606 fbshipit-source-id: 972259e7ebecb19b55aef2ef866bd7cb57aaf0ca
|
This pull request has been merged in f6c4a8e. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1482 Pull Request resolved: facebook#41685 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606 fbshipit-source-id: 972259e7ebecb19b55aef2ef866bd7cb57aaf0ca
tungdo194
pushed a commit
to tungdo194/rn-test
that referenced
this pull request
Apr 28, 2024
Summary: X-link: facebook/yoga#1482 This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to `calculateLayoutInternal` that is in `layoutAbsoluteChild` Reviewed By: NickGerleman Differential Revision: D51293606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebook/react-native#41685
This is the final step (that I know of) to get the core features of static working. Here we turn on all of the tests and pass down the correct owner size for the call to
calculateLayoutInternalthat is inlayoutAbsoluteChildReviewed By: NickGerleman
Differential Revision: D51293606