Fix handling 'auto' checks in absolute layout

[coado]

Summary:

Regarding issue with incorrect layout when left is set to auto. This PR introduces handling auto whenever inline or flex position is checked to be defined and it fixes above issue.

Tests:

I have run the provided unit tests and everything passes.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
yoga-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 27, 2024 10:55am

[NickGerleman]

Could you please add tests?

[coado]

I've added three tests. The first one sets on component left: auto, the second one right: auto, and the last one both left: auto and right: auto. Also, I've noticed that cpp and js test generators were wrongly creating functions that set auto on edges, so I've fixed that. The deployment is failing, so I may be missing something. Please let me know what's wrong and I will fix that.

[NickGerleman]

Looks like the JavaScript binding changes do not compile. See error here: https://github.com/facebook/yoga/actions/runs/10510442433/job/29131043181?pr=1689#logs

[NickGerleman]

Yay, that fixed the JavaScript build. But tests in JavaScript fail with an exception, indicating something isn't being bound correctly. https://github.com/facebook/yoga/actions/runs/10521212923/job/29151469086?pr=1689

Summary of all failing tests
 FAIL  tests/generated/YGAbsolutePositionTest.test.ts
  ● absolute_layout_width_height_left_auto_right

    TypeError: root_child0.setPositionAuto is not a function

      88 |     const root_child0 = Yoga.Node.create(config);
      89 |     root_child0.setPositionType(PositionType.Absolute);
    > 90 |     root_child0.setPositionAuto(Edge.Left);
         |                 ^
      91 |     root_child0.setPosition(Edge.Right, 10);
      92 |     root_child0.setWidth(10);
      93 |     root_child0.setHeight(10);

      at Object.setPositionAuto (tests/generated/YGAbsolutePositionTest.test.ts:90:17)

[coado]

Yay, that fixed the JavaScript build. But tests in JavaScript fail with an exception, indicating something isn't being bound correctly. https://github.com/facebook/yoga/actions/runs/10521212923/job/29151469086?pr=1689

Summary of all failing tests
 FAIL  tests/generated/YGAbsolutePositionTest.test.ts
  ● absolute_layout_width_height_left_auto_right

    TypeError: root_child0.setPositionAuto is not a function

      88 |     const root_child0 = Yoga.Node.create(config);
      89 |     root_child0.setPositionType(PositionType.Absolute);
    > 90 |     root_child0.setPositionAuto(Edge.Left);
         |                 ^
      91 |     root_child0.setPosition(Edge.Right, 10);
      92 |     root_child0.setWidth(10);
      93 |     root_child0.setHeight(10);

      at Object.setPositionAuto (tests/generated/YGAbsolutePositionTest.test.ts:90:17)

Thanks! I pushed change that should fix JS tests

[NickGerleman]

This doesn't seem valid

[NickGerleman]

More generally, I think these tests assume JNI bindings for the Java Node exist to the new API.

Annoyingly, we don't build or run Java tests in GitHub Actions right now, but it is run when we import it into Phabricator. It's usually pretty straightforward to pattern match these JNI bindings, and I can relay any build/test failures if they happen.

[coado]

Okay, I can see that there is no setPositionAuto function for Java too.

[NickGerleman]

Yep! That and generating YogaConstants.AUTOf (with the extraneous "f")

[coado]

@NickGerleman I've pushed the fix for java. I am unsure if it works 😅

[facebook-github-bot]

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@NickGerleman merged this pull request in 6d6f69b.