Make it so that aspect ratio behaves like auto if it is 0 or inf #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request was exported from Phabricator. Differential Revision: D62473161 |
|
This pull request was exported from Phabricator. Differential Revision: D62473161 |
joevilches
added a commit
to joevilches/yoga
that referenced
this pull request
Sep 12, 2024
…ebook#1696) Summary: X-link: facebook/react-native#46428 Pull Request resolved: facebook#1696 We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62473161
joevilches
force-pushed
the
export-D62473161
branch
from
7ce2b97
to
448a8c7
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Sep 12, 2024
…ebook#46428) Summary: Pull Request resolved: facebook#46428 X-link: facebook/yoga#1696 We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62473161
…ebook#1696) Summary: X-link: facebook/react-native#46428 Pull Request resolved: facebook#1696 We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62473161
|
This pull request was exported from Phabricator. Differential Revision: D62473161 |
joevilches
force-pushed
the
export-D62473161
branch
from
448a8c7
to
51efede
Compare
joevilches
added a commit
to joevilches/react-native
that referenced
this pull request
Sep 12, 2024
…ebook#46428) Summary: Pull Request resolved: facebook#46428 X-link: facebook/yoga#1696 We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62473161
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 12, 2024
) Summary: Pull Request resolved: #46428 X-link: facebook/yoga#1696 We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62473161 fbshipit-source-id: 6857de819538a7a87ce0a652e99f5a49992921ae
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Sep 12, 2024
Summary: X-link: facebook/react-native#46428 X-link: facebook/yoga#1696 We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D62473161 fbshipit-source-id: 6857de819538a7a87ce0a652e99f5a49992921ae
|
This pull request has been merged in a112a07. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: We do not validate the aspect ratio to ensure it is non zero and non inf in a lot of places. Per the spec, these values should act like auto. There is no auto keyword, but it is the default so I just set the style to a default FloatOptional in this case
Differential Revision: D62473161