Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Node.h's getResolvedDimension to getDimensionLength #1705

Closed
wants to merge 1 commit into from
Closed

Rename Node.h's getResolvedDimension to getDimensionLength #1705

wants to merge 1 commit into from

Commits on Sep 30, 2024

  1. Rename Node.h's getResolvedDimension to getProcessedDimension (facebo… 

    …ok#1705)

Summary:
X-link: facebook/react-native#46649

Pull Request resolved: facebook#1705

To get the height and width we call a function currently named `getResolvedDimension`. This returns a `Style::Length`, which in most cases we "resolve" immediately by calling `resolve`. This is a bit confusing that you need to `resolve` something that is already `resolved`.

I plan on adding a new function soon for `contextBox` which would resolve the length for you, so I think this should be renamed.

Also deleted unused `getResolvedDimensions`

Changelog: [Internal]

Reviewed By: NickGerleman

Differential Revision: D63407730
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    da55e15 View commit details
    Browse the repository at this point in the history