-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"./zstreamtest --newapi" test case fails on Windows #3119
Comments
@eli-schwartz are you able to reproduce the error consistently? |
My only windows test environment is GitHub actions. In that environment I could consistently produce these results while doing debug iteration. (This is the same debug iteration in which I discovered the valgrind issue I was facing etc. in my other PR.) |
It was also reproducible at the end of January (again in the WrapDB github actions CI), as I mentioned this exact problem here: #3039 (comment) |
I've tried to reproduce it. On Windows + Mingw64, I could finally reproduce it. Suspecting an issue with the multi-threading code currently, as the MT code on windows uses a shim translation layer, not So that's a potential investigation direction. Also worth noting : This seems to point at MT + Windows + malloc combination problem. |
Note that in the preamble to my CI logs I linked above, it prints messages pointing out that the detected / used compiler is cl.exe (msvc 19.31.31105) and the linker is link.exe -- and of course there too it is not using the msys2 posix compatibility layer. Thanks for confirming the issue. :) The fact that it happens due to MALLOC_PERTURB_ is interesting... Meson sets this as described at https://mesonbuild.com/Unit-tests.html#malloc_perturb_ and it can be disabled if needed, though catching malloc problems does seem like that feature was useful in exposing an issue? |
Yes, I think |
I retract that statement. |
This is properly fixed by #3364 (not yet merged, but passes this test case in CI now). |
Fix has been merged. Thanks! |
In the Meson WrapDB integration CI, we try to run the build && test on all 3 major OSes. On Windows, one of the tests fails. Logs: https://github.com/mesonbuild/wrapdb/runs/6086663524?check_suite_focus=true
Relevant bits:
It is dying of a strange signal apparently. I've grepped around the source tree, and --newapi is only exercised by the Makefile and by the meson.build, and neither one is getting run on Windows-based CI jobs.
The text was updated successfully, but these errors were encountered: