-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[memory opt] Downsize decompression buffers when large for too long #2069
Conversation
Please add a test, you should be able to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good overall. Suggestions inline.
Looks good to me. It's a clean patch, great work @bimbashrestha ! And just FYI, since I did not participate on earlier discussion on this topic, I was not opposed on having separate constants for compression and decompression states, since it would allow differentiated policy if need be. But indeed, the names of constants should reflect their respective scope. That being said, there's no urgency. We can start by using the same constants and therefore same policy for both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the test is added.
#2066