Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the problem of successful decompression using -T parameter #2920

Closed
wants to merge 4 commits into from
Closed

Fix the problem of successful decompression using -T parameter #2920

wants to merge 4 commits into from

Conversation

15596858998
Copy link
Contributor

@15596858998 15596858998 closed this Dec 9, 2021
@15596858998 15596858998 reopened this Dec 9, 2021
@15596858998 15596858998 closed this Dec 9, 2021
@15596858998 15596858998 reopened this Dec 9, 2021
@15596858998 15596858998 closed this Dec 9, 2021
@15596858998 15596858998 reopened this Dec 9, 2021
@15596858998 15596858998 closed this Dec 9, 2021
felixhandte
felixhandte reviewed Dec 9, 2021
View reviewed changes
Copy link
Contributor

@felixhandte felixhandte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At most, this should be a warning.

I also think you can probably just look at nbWorkers > 1 rather than define a new variable.

programs/zstdcli.c
@@ -1352,6 +1354,13 @@ int main(int argCount, const char* argv[])
}
}

if (useTparam) {
if (operation == zom_decompress) {
DISPLAY("error : can't use -T in decomrpession mode \n");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please fix the spelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixhandte felixhandte felixhandte left review comments

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@15596858998 @felixhandte @facebook-github-bot