Simplify HUF_decompress4X2_usingDTable_internal_bmi2_asm_loop #3013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the asm code (great job, by the way!), I noticed that it's possible to remove three divisions by 10. The original expression was:
The division by 10 can be moved outside
min
:make test
passed. I check on an Ice Lake machine that there's no performance regression.zstd -i5 -b1 1MBfile
showed 1194 MB/s for the currentdev
, with this change 1201 MB/s.