Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required decompression memory usage reported by -vv + --long #3042

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Fix required decompression memory usage reported by -vv + --long #3042

merged 1 commit into from
Feb 4, 2022

Commits on Feb 2, 2022

  1. Fix required decompression memory usage reported by -vv + --long 

    The use of --long alters the window size internally in the underlying
library (lib/compress/zstd_compress.c:ZSTD_getCParamsFromCCtxParams),
which changes the memory required for decompression. This means that the
reported requirement from the zstd binary when -vv is specified is
incorrect.

A full fix for this would be to add an API call to be able to retrieve
the required decompression memory from the library, but as a
lighterweight fix we can just take account of the fact we've enabled
long mode and update our verbose output appropriately.

Fixes facebook#2968
    @u1f35c
    u1f35c committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    470eb83 View commit details
    Browse the repository at this point in the history