Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build:cmake: enable ZSTD legacy support by default #3079

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

niamster
Copy link
Contributor

@niamster niamster commented Mar 1, 2022

I would like to enable support of legacy formats in CMAKE builds by default.

Backwards compatibility is by default enabled for the VS, make and meson builds, and disabled for cmake and single-file builds.

I think single-file build is special, so it makes sense keep it disabled.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Mar 1, 2022

Good point, I agree it makes sense to have cmake build script on par with other build systems (and reference make).

@niamster
Copy link
Contributor Author

niamster commented Mar 4, 2022

Good point, I agree it makes sense to have cmake build script on par with other build systems (and reference make).

@Cyan4973 Thank you for sharing your opinion! Can you please suggest me what I should do to get an approval?

@niamster
Copy link
Contributor Author

niamster commented Mar 4, 2022

Thanks @Cyan4973 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants