Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AIX] Fix Compiler Flags and Bugs on AIX to Pass All Tests #3219

Merged
merged 5 commits into from
Jul 29, 2022
Merged

[AIX] Fix Compiler Flags and Bugs on AIX to Pass All Tests #3219

merged 5 commits into from
Jul 29, 2022

Conversation

qiongsiwu
Copy link
Contributor

This PR fixes:

  • Code that triggers compiler warnings (unused argument and function prototype warnings)
  • The -s compiler flag that is no longer supported by newer versions of clang. It is replaced by -Wl,-s.
  • malloc of size zero returns 0 on AIX, causing the dict-builder/no-inputs.sh test case to fail.

terrelln
terrelln approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @qiongsiwu! Looks good to me!

@terrelln terrelln merged commit b1bbb0e into facebook:dev Jul 29, 2022
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrelln terrelln terrelln approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiongsiwu @terrelln @facebook-github-bot