Add explicit --pass-through flag and default to enabled for *cat #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrelln
force-pushed
the
issue-3211-pass-through
branch
from
94366a9
to
a79ca74
Compare
|
This looks awesome, thanks for the work in getting this done! |
terrelln
force-pushed
the
issue-3211-pass-through
branch
from
a79ca74
to
021e4d5
Compare
Fixes facebook#3211. Adds the `--[no-]pass-through` flag which enables/disables pass-through mode. * `zstdcat`, `zcat`, and `gzcat` default to `--pass-through`. Pass-through mode can be disabled by passing `--no-pass-through`. * All other binaries default to not setting pass-through mode. However, we preserve the legacy behavior of enabling pass-through mode when writing to stdout with `-f` set, unless pass-through mode is explicitly disabled with `--no-pass-through`. Adds a new test for this behavior that should codify the behavior we want.
terrelln
force-pushed
the
issue-3211-pass-through
branch
from
021e4d5
to
1fcfc1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3211.
Adds the
--[no-]pass-throughflag which enables/disables pass-through mode.zstdcat,zcat, andgzcatdefault to--pass-through.Pass-through mode can be disabled by passing
--no-pass-through.However, we preserve the legacy behavior of enabling pass-through
mode when writing to stdout with
-fset, unless pass-throughmode is explicitly disabled with
--no-pass-through.Adds a new test for this behavior that should codify the behavior we want.