Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test pkg-config file #3267

Merged
merged 1 commit into from
Sep 22, 2022
Merged

ci: test pkg-config file #3267

merged 1 commit into from
Sep 22, 2022

Conversation

Tachi107
Copy link
Contributor

As mentioned in #3252 (comment), this patch adds a CI job that builds and installs libzstd on the job runner, and then compiles a sample binary linking against the installed library; the needed build flags are passed by invoking pkg-config.

As mentioned in
facebook#3252 (comment) ,
this patch adds a CI job that builds and installs libzstd on the job
runner, and then compiles a sample binary linking against the installed
library; the needed build flags are passed by invoking pkg-config.
- name: Install dependencies
run: |
apt -y update
apt -y install --no-install-recommends gcc libc6-dev make pkg-config
Copy link
Contributor Author

@Tachi107 Tachi107 Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added --no-install-recommends just to speed up the job by a few seconds.
It skips the installation of things like manpages that are not needed on a headless build server.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Sep 22, 2022

Thanks for adding this useful CI test @Tachi107 !

The lone CI error is unrelated to this PR, and was recently fixed by @yoniko in #3272

@Cyan4973 Cyan4973 merged commit 43962d7 into facebook:dev Sep 22, 2022
@Tachi107 Tachi107 deleted the pkg-config-ci branch September 22, 2022 19:33
@Tachi107
Copy link
Contributor Author

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants