Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed zstd-pgo target for GCC #3281

Merged
merged 2 commits into from
Oct 8, 2022
Merged

fixed zstd-pgo target for GCC #3281

merged 2 commits into from
Oct 8, 2022

Commits on Oct 5, 2022

  1. fixed zstd-pgo target for GCC 

    Since your Makefile uses obj/$(HASH_DIR) for object files, this code does not work correctly for GCC. Because profiles are saved in one directory, and are expected in another when reading.

`$(RM) zstd *.o` - this line doesn't delete object files.

Clang stores profiles in the current directory, so the problem doesn't appear when compiling with Clang.

Also this code will work if BUILD_DIR is set.
    @ilyakurdyukov
    ilyakurdyukov authored Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2ffcb2d View commit details
    Browse the repository at this point in the history

  2. zstd-pgo: also clean zstd binary from objects 

    Just a precaution, because it works anyway.
    @ilyakurdyukov
    ilyakurdyukov authored Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2bd70ef View commit details
    Browse the repository at this point in the history