-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimal huff depth speed improvements #3302
Merged
daniellerozenblit
merged 12 commits into
facebook:dev
from
daniellerozenblit:optimal-huff-depth-speed
Jan 3, 2023
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a08fabd
Rough draft speed optimization
daniellerozenblit b4f0d36
Merge
daniellerozenblit 4013319
Commit for benchmarking
daniellerozenblit db74d04
Speed optimizations with macro
daniellerozenblit 0e1de8a
Merge branch 'facebook:dev' into optimal-huff-depth-speed
daniellerozenblit c263821
Change threshold for benchmarking
daniellerozenblit 326e442
Merge branch 'facebook:dev' into optimal-huff-depth-speed
daniellerozenblit 482689b
huf log speed optimization: unidirectional scan of logs + break when …
daniellerozenblit 2def93b
Merge branch 'optimal-huff-depth-speed' of github.com:daniellerozenbl…
daniellerozenblit c26f348
fix CI errors
daniellerozenblit df714dd
implement suggestions
daniellerozenblit 87becc5
update regression results.csv
daniellerozenblit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor optimization :
If the tree builder is unable to use all allowed bits anyway, it means we have already reached the optimal huffman distribution at previous attempt. We can immediately stop the loop, as it will bring no further benefit.
Tested on
silesia.tar
with 1 KB blocks : this seems to improve compression speed by ~+1%, at no impact on compression ratio.