Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: get version up front #3327

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

eli-schwartz
Copy link
Contributor

Run the scraper command to establish the project version immediately, rather than wait for the build to be configured. This simplifies the code and ensures that project introspection works correctly.

Run the scraper command to establish the project version immediately,
rather than wait for the build to be configured. This simplifies the
code and ensures that project introspection works correctly.
@Cyan4973
Copy link
Contributor

Cyan4973 commented Dec 1, 2022

I like it. It indeed feels more logical.

@Cyan4973 Cyan4973 merged commit e873335 into facebook:dev Dec 1, 2022
@eli-schwartz eli-schwartz deleted the meson-version-simplify branch December 1, 2022 23:45
@Cyan4973 Cyan4973 mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants