-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Window Resizing Edge Case #3345
Fix Window Resizing Edge Case #3345
Conversation
Would it be possible to add an associated test in |
I'd recommend adding a test to https://github.com/facebook/zstd/tree/dev/tests/cli-tests/compression |
zstd --long=31 -1 --single-thread --no-content-size -f file | ||
zstd -l -v file.zst | ||
|
||
# We want to ignore stderr (its outputting "*** zstd command line interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One way to silence stderr
could be 2> /dev/null
(redirects stderr
to /dev/null
)
@@ -0,0 +1 @@ | |||
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor : I'm wondering what happens if this file is not provided, or if it is replaced by the *.ignore
suffix variant.
This could be a more explicit way to express that stderr
output is not significant.
cc @terrelln .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the .ignore
suffix seems to work! I can switch to that, I like that it is a bit more explicit than redirection.
This PR fixes the bug addressed in #3239.
I have implemented the fix proposed and have validated that the issue no longer occurs.