[tests] Fix version test determinism #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrelln
force-pushed
the
2022-12-20-version-test-fix
branch
20 times, most recently
from
0f2feb7
to
c63ba5a
Compare
|
Alright, I've run the version test ~250 times and have seen no failures. It seems to be either consistently passing, or consistently failing. So I will resume debugging if it starts failing again on PRs, and hope I can repro it then. |
terrelln
force-pushed
the
2022-12-20-version-test-fix
branch
4 times, most recently
from
1393e26
to
4e47051
Compare
terrelln
changed the title
|
Still haven't been able to reproduce the failure, but this PR now makes the tests more deterministic, and should help us debug if the failure shows up again. |
The dictionary source files were taken from the `dev` branch before this commit, which could introduce non-determinism on PR jobs. Instead take the sources from the PR checkout. This PR also adds stderr logging, and verbose output for the jobs that are failing, to help catch the failure if it occurs again.
Cyan4973
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dictionary source files were taken from the
devbranch before thiscommit, which could introduce non-determinism on PR jobs. Instead take
the sources from the PR checkout.
This PR also adds stderr logging, and verbose output for the jobs that
are failing, to help catch the failure if it occurs again.