Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit deletes all unused Huffman functions.
The second commit replaces boolean parameters (
bmi2
,suspectUncompressible
,preferRepeat
,optimalDepth
) with aflags
bit field. This makes it easier to add flags, and makes the parameter list shorter. I've also added another flagdisableAsm
which disables the assembly decompressor, which is useful for fuzzing. I've renamed the functions to remove the_bmi2()
suffix, since the first commit deleted all the non-bmi2 variants.In a stacked PR, I will be adding a fast C variant of the decoders, and will add another flag
disableFast
, which will allow us to opt out of the fast decoder for fuzzing. This is the motivation for switching to theflags
.