Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzz the Block-Level Sequence Producer API #3437

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Fuzz the Block-Level Sequence Producer API #3437

merged 2 commits into from
Jan 20, 2023

Conversation

embg
Copy link
Contributor

@embg embg commented Jan 19, 2023

Adds external matchfinder registration to FUZZ_setRandomParameters(). This allows the fuzzers to catch 3/4 of the bugs from #3433. (The 4th bug is captured in zstreamtest.c). I ran the fuzzers overnight and did not find any new crashes, only timeouts and one OOM (these don't indicate real bugs in zstd).

@embg embg changed the title Fuzz the external matchfinder API Fuzz the External Matchfinder API Jan 19, 2023
@embg embg requested a review from terrelln January 19, 2023 22:13
Copy link
Contributor

@terrelln terrelln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one minor suggestion

tests/fuzz/zstd_helpers.c Outdated Show resolved Hide resolved
Co-authored-by: Nick Terrell <nickrterrell@gmail.com>
@embg embg merged commit 64963dc into facebook:dev Jan 20, 2023
@embg embg deleted the fuzz_emf branch January 20, 2023 16:43
@embg embg changed the title Fuzz the External Matchfinder API Fuzz the External Sequence Producer API Feb 8, 2023
@embg embg changed the title Fuzz the External Sequence Producer API Fuzz the Block-Level Sequence Producer API Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants