Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zstd][android] Fix build with NDK r27 #4107

Merged
merged 1 commit into from
Jul 30, 2024
Merged

[zstd][android] Fix build with NDK r27 #4107

merged 1 commit into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. [zstd][android] Fix build with NDK r27 

    The NDK cross compiler declares the target as __linux (which is
not technically incorrect), which triggers the enablement of _GNU_SOURCE
in the newly added code that requires the presence of qsort_r() used
in the COVER dictionary code.

Even though the NDK uses llvm/libc, it doesn't declare qsort_r()
in the stdlib.h header.

The build fix is to only activate the _GNU_SOURCE macro if the OS is
*not* Android, as then we will fallback to the C90 compliant code.

This patch should solve the reported issue number facebook#4103.
    Adenilson Cavalcanti committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    c3c28c4 View commit details
    Browse the repository at this point in the history