[riscv] Enable support for weak symbols #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both gcc and clang support weak symbols on RISC-V, therefore let's enable it. This should fix issue facebook#4069.
Cyan4973
approved these changes
Aug 7, 2024
Cyan4973
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
I presume this change is automatically tested as part of :
https://github.com/facebook/zstd/actions/runs/10275661201/job/28434730175?pr=4114
In which case, it looks all good to me
|
@Cyan4973 I also compiled/run zstd in a real RISC-V board (built with both gcc 13.2.1 and clang-18) to ensure that it should be all fine. That being said, I think it is pretty cool that zstd already has a RISC-V test/bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both gcc and clang support weak symbols on RISC-V, therefore let's enable it.
This should fix issue #4069.