Skip to content
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Switch TOML implementation to toml_edit #492

Open
sunshowers opened this issue Nov 20, 2021 · 0 comments
Open

Switch TOML implementation to toml_edit #492

sunshowers opened this issue Nov 20, 2021 · 0 comments

Comments

@sunshowers
Copy link
Contributor

toml_edit looks like the future of toml parsing and serialization in Rust: its design avoids ValueAfterTable issues, provides greater control over formatting if necessary, etc. I think it makes sense to switch to it at some point. Filing this task to keep track of blocking issues.

@sunshowers sunshowers changed the title Switch TOML implmentation to toml_edit Switch TOML implementation to toml_edit Nov 20, 2021
sunshowers added a commit to sunshowers/cargo-guppy that referenced this issue Nov 20, 2021
This means that the same library can parse summaries created by both old
and new versions of guppy. We don't use the summary for much anyway,
currently.

I also looked at switching to `toml_edit`, which has a much better
design overall. Unfortunately, I ran into
toml-rs/toml#192. It makes sense to switch
to `toml_edit` at some point in the future, and I've filed facebookarchive#492 to keep
track of that.
sunshowers added a commit to sunshowers/cargo-guppy that referenced this issue Nov 23, 2021
This means that the same library can parse summaries created by both old
and new versions of guppy. We don't use the summary for much anyway,
currently.

I also looked at switching to `toml_edit`, which has a much better
design overall. Unfortunately, I ran into
toml-rs/toml#192. It makes sense to switch
to `toml_edit` at some point in the future, and I've filed facebookarchive#492 to keep
track of that.
sunshowers added a commit that referenced this issue Nov 23, 2021
This means that the same library can parse summaries created by both old
and new versions of guppy. We don't use the summary for much anyway,
currently.

I also looked at switching to `toml_edit`, which has a much better
design overall. Unfortunately, I ran into
toml-rs/toml#192. It makes sense to switch
to `toml_edit` at some point in the future, and I've filed #492 to keep
track of that.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant