Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Commit

Permalink
Bring back the ariaOwneeID prop. (#1883)
Browse files Browse the repository at this point in the history
Summary:
**Summary**

Reverts 7f0cab2 to bring back the `ariaOwneeID` prop. The ARIA property `aria-owns` is required for the combobox ARIA widget, in both ARIA 1.0 and 1.1. Some plugins, for example the Mentions and Emoji plugins, still pass an `ariaOwneeID` prop which at the moment doesn't do anything. Also, without `aria-owns`, some browser / screen reader combinations don't read out the suggestions at all. For more details please refer to the related issue #1736.

Fixes #1736.
Pull Request resolved: #1883

Reviewed By: vdurmont

Differential Revision: D10371390

Pulled By: vdurmont

fbshipit-source-id: 140282124128437e0d8cc9b08490420c3dc81dc1
  • Loading branch information
afercia authored and facebook-github-bot committed Oct 24, 2018
1 parent 4a9a6a8 commit ce7f677
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/component/base/DraftEditor.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,7 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
aria-label={this.props.ariaLabel}
aria-labelledby={this.props.ariaLabelledBy}
aria-multiline={this.props.ariaMultiline}
aria-owns={readOnly ? null : this.props.ariaOwneeID}
autoCapitalize={this.props.autoCapitalize}
autoComplete={this.props.autoComplete}
autoCorrect={this.props.autoCorrect}
Expand Down
1 change: 1 addition & 0 deletions src/component/base/DraftEditorProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ export type DraftEditorProps = {
ariaLabel?: string,
ariaLabelledBy?: string,
ariaMultiline?: boolean,
ariaOwneeID?: string,

webDriverTestID?: string,

Expand Down

0 comments on commit ce7f677

Please sign in to comment.