This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Adds iframed editor example #1879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
In Chrome 69.0.3497.100, MacOS, the example does not work (even by starting a python http server). clicking on editor will throw a typing will throw a |
|
Yes, it won't work until we ship #1877 |
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Adds an iframed editor example to Draft.js based on haikyuu's CodeSandbox demo https://codesandbox.io/s/y0q1q281kz **Test Plan** ``` git clone claudiopro/draft-js . cd draft-js git checkout iframe-example python3 -m http.server 8000 open http://localhost:8000/examples/draft-0-10-0/iframe/iframe.html ``` <img width="1072" alt="screen shot 2018-09-24 at 4 23 24 pm" src="https://user-images.githubusercontent.com/860099/45957816-396c1c00-c016-11e8-9808-c4453ff6c4ff.png"> Pull Request resolved: facebookarchive#1879 Differential Revision: D10194094 fbshipit-source-id: 0beabd7b890fbc31acdc84a780d6e91ca1de31a4
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Adds an iframed editor example to Draft.js based on haikyuu's CodeSandbox demo https://codesandbox.io/s/y0q1q281kz **Test Plan** ``` git clone claudiopro/draft-js . cd draft-js git checkout iframe-example python3 -m http.server 8000 open http://localhost:8000/examples/draft-0-10-0/iframe/iframe.html ``` <img width="1072" alt="screen shot 2018-09-24 at 4 23 24 pm" src="https://user-images.githubusercontent.com/860099/45957816-396c1c00-c016-11e8-9808-c4453ff6c4ff.png"> Pull Request resolved: facebookarchive/draft-js#1879 Differential Revision: D10194094 fbshipit-source-id: 0beabd7b890fbc31acdc84a780d6e91ca1de31a4
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Adds an iframed editor example to Draft.js based on haikyuu's CodeSandbox demo https://codesandbox.io/s/y0q1q281kz **Test Plan** ``` git clone claudiopro/draft-js . cd draft-js git checkout iframe-example python3 -m http.server 8000 open http://localhost:8000/examples/draft-0-10-0/iframe/iframe.html ``` <img width="1072" alt="screen shot 2018-09-24 at 4 23 24 pm" src="https://user-images.githubusercontent.com/860099/45957816-396c1c00-c016-11e8-9808-c4453ff6c4ff.png"> Pull Request resolved: facebookarchive/draft-js#1879 Differential Revision: D10194094 fbshipit-source-id: 0beabd7b890fbc31acdc84a780d6e91ca1de31a4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds an iframed editor example to Draft.js based on @haikyuu's CodeSandbox demo https://codesandbox.io/s/y0q1q281kz
Test Plan