Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Update webpack-dev-server & babel version in TeX examples #1981

Closed
wants to merge 1 commit into from

Conversation

niveditc
Copy link
Contributor

Summary

  • Upgrade webpack-dev-server to 3.1.14 to fix vulnerability in versions < 3.1.11 & webpack to 4.0.0 to match it
  • Upgrade babel to 6.0.0 & babel-loader to 7.0.0 to match webpack upgrade
  • Changes to server.js & app.js to support the webpack & babel version upgrades

Test Plan
Run yarn start and load http://localhost:3000/
screenshot 2019-01-21 13 22 30

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niveditc has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@claudiopro
Copy link
Contributor

This is awesome, thanks for addressing a security vulnerability and modernizing the examples!

jdecked pushed a commit to twitter-forks/draft-js that referenced this pull request Oct 9, 2019
…chive#1981)

Summary:
**Summary**
* Upgrade `webpack-dev-server` to 3.1.14 to fix [vulnerability in versions < 3.1.11](https://nvd.nist.gov/vuln/detail/CVE-2018-14732) & `webpack` to 4.0.0 to match it
* Upgrade `babel` to 6.0.0 & `babel-loader` to 7.0.0 to match `webpack` upgrade
* Changes to `server.js` & `app.js` to support the `webpack` & `babel` version upgrades

**Test Plan**
Run `yarn start` and load http://localhost:3000/
<img width="1089" alt="screenshot 2019-01-21 13 22 30" src="https://user-images.githubusercontent.com/2357761/51502558-5974d780-1d8b-11e9-8568-917f43967188.png">
Pull Request resolved: facebookarchive#1981

Reviewed By: claudiopro

Differential Revision: D13754649

Pulled By: claudiopro

fbshipit-source-id: 19169f9b091d85344d975e2d7b963437b7701e9b
alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
**Summary**
* Upgrade `webpack-dev-server` to 3.1.14 to fix [vulnerability in versions < 3.1.11](https://nvd.nist.gov/vuln/detail/CVE-2018-14732) & `webpack` to 4.0.0 to match it
* Upgrade `babel` to 6.0.0 & `babel-loader` to 7.0.0 to match `webpack` upgrade
* Changes to `server.js` & `app.js` to support the `webpack` & `babel` version upgrades

**Test Plan**
Run `yarn start` and load http://localhost:3000/
<img width="1089" alt="screenshot 2019-01-21 13 22 30" src="https://user-images.githubusercontent.com/2357761/51502558-5974d780-1d8b-11e9-8568-917f43967188.png">
Pull Request resolved: facebookarchive/draft-js#1981

Reviewed By: claudiopro

Differential Revision: D13754649

Pulled By: claudiopro

fbshipit-source-id: 19169f9b091d85344d975e2d7b963437b7701e9b
aforismesen added a commit to aforismesen/draft-js that referenced this pull request Jul 12, 2024
Summary:
**Summary**
* Upgrade `webpack-dev-server` to 3.1.14 to fix [vulnerability in versions < 3.1.11](https://nvd.nist.gov/vuln/detail/CVE-2018-14732) & `webpack` to 4.0.0 to match it
* Upgrade `babel` to 6.0.0 & `babel-loader` to 7.0.0 to match `webpack` upgrade
* Changes to `server.js` & `app.js` to support the `webpack` & `babel` version upgrades

**Test Plan**
Run `yarn start` and load http://localhost:3000/
<img width="1089" alt="screenshot 2019-01-21 13 22 30" src="https://user-images.githubusercontent.com/2357761/51502558-5974d780-1d8b-11e9-8568-917f43967188.png">
Pull Request resolved: facebookarchive/draft-js#1981

Reviewed By: claudiopro

Differential Revision: D13754649

Pulled By: claudiopro

fbshipit-source-id: 19169f9b091d85344d975e2d7b963437b7701e9b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants