This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claudiopro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
Summary: **Summary** Removes unused dev dependency on `gulp-browserify-thin`. Addresses a security vulnerability that affects `minimatch@2.0.10` indirectly required through this module. ``` → yarn why minimatch Using globally installed version of Yarn yarn why v1.12.1 [1/4] � Why do we have the module "minimatch"...? [2/4] 🚚 Initialising dependency graph... [3/4] 🔍 Finding dependency... [4/4] 🚡 Calculating file sizes... => Found "minimatch@3.0.4" info Has been hoisted to "minimatch" info Reasons this module exists - Hoisted from "eslint#minimatch" - Hoisted from "glob#minimatch" - Hoisted from "gulp-if#gulp-match#minimatch" - Hoisted from "jest#jest-cli#istanbul-api#minimatch" - Hoisted from "gulp-concat-css#rework-import#globby#glob#minimatch" - Hoisted from "envify#jstransform#commoner#glob#minimatch" - Hoisted from "jest#jest-cli#istanbul-api#fileset#minimatch" - Hoisted from "jest#jest-cli#jest-runtime#babel-plugin-istanbul#test-exclude#minimatch" - Hoisted from "gulp#glob-watcher#chokidar#fsevents#node-pre-gyp#npm-packlist#ignore-walk#minimatch" info Disk size without dependencies: "44KB" info Disk size with unique dependencies: "64KB" info Disk size with transitive dependencies: "120KB" info Number of shared dependencies: 1 => Found "browserify#minimatch@2.0.10" info Reasons this module exists - "gulp-browserify-thin#browserify#glob" depends on it - Hoisted from "gulp-browserify-thin#browserify#glob#minimatch" info Disk size without dependencies: "76KB" info Disk size with unique dependencies: "96KB" info Disk size with transitive dependencies: "152KB" info Number of shared dependencies: 1 ✨ Done in 0.96s. ``` **Test Plan** Check if `gulp-browserify-thin` is required anywhere, it is not. Pull Request resolved: facebookarchive#2032 Reviewed By: mrkev Differential Revision: D14388097 Pulled By: mrkev fbshipit-source-id: 6b9b46ec8129d7899805021fbd6d6d1f8b9e443b
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: **Summary** Removes unused dev dependency on `gulp-browserify-thin`. Addresses a security vulnerability that affects `minimatch@2.0.10` indirectly required through this module. ``` → yarn why minimatch Using globally installed version of Yarn yarn why v1.12.1 [1/4] � Why do we have the module "minimatch"...? [2/4] 🚚 Initialising dependency graph... [3/4] 🔍 Finding dependency... [4/4] 🚡 Calculating file sizes... => Found "minimatch@3.0.4" info Has been hoisted to "minimatch" info Reasons this module exists - Hoisted from "eslint#minimatch" - Hoisted from "glob#minimatch" - Hoisted from "gulp-if#gulp-match#minimatch" - Hoisted from "jest#jest-cli#istanbul-api#minimatch" - Hoisted from "gulp-concat-css#rework-import#globby#glob#minimatch" - Hoisted from "envify#jstransform#commoner#glob#minimatch" - Hoisted from "jest#jest-cli#istanbul-api#fileset#minimatch" - Hoisted from "jest#jest-cli#jest-runtime#babel-plugin-istanbul#test-exclude#minimatch" - Hoisted from "gulp#glob-watcher#chokidar#fsevents#node-pre-gyp#npm-packlist#ignore-walk#minimatch" info Disk size without dependencies: "44KB" info Disk size with unique dependencies: "64KB" info Disk size with transitive dependencies: "120KB" info Number of shared dependencies: 1 => Found "browserify#minimatch@2.0.10" info Reasons this module exists - "gulp-browserify-thin#browserify#glob" depends on it - Hoisted from "gulp-browserify-thin#browserify#glob#minimatch" info Disk size without dependencies: "76KB" info Disk size with unique dependencies: "96KB" info Disk size with transitive dependencies: "152KB" info Number of shared dependencies: 1 ✨ Done in 0.96s. ``` **Test Plan** Check if `gulp-browserify-thin` is required anywhere, it is not. Pull Request resolved: facebookarchive#2032 Reviewed By: mrkev Differential Revision: D14388097 Pulled By: mrkev fbshipit-source-id: 6b9b46ec8129d7899805021fbd6d6d1f8b9e443b
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Removes unused dev dependency on `gulp-browserify-thin`. Addresses a security vulnerability that affects `minimatch@2.0.10` indirectly required through this module. ``` → yarn why minimatch Using globally installed version of Yarn yarn why v1.12.1 [1/4] � Why do we have the module "minimatch"...? [2/4] 🚚 Initialising dependency graph... [3/4] 🔍 Finding dependency... [4/4] 🚡 Calculating file sizes... => Found "minimatch@3.0.4" info Has been hoisted to "minimatch" info Reasons this module exists - Hoisted from "eslint#minimatch" - Hoisted from "glob#minimatch" - Hoisted from "gulp-if#gulp-match#minimatch" - Hoisted from "jest#jest-cli#istanbul-api#minimatch" - Hoisted from "gulp-concat-css#rework-import#globby#glob#minimatch" - Hoisted from "envify#jstransform#commoner#glob#minimatch" - Hoisted from "jest#jest-cli#istanbul-api#fileset#minimatch" - Hoisted from "jest#jest-cli#jest-runtime#babel-plugin-istanbul#test-exclude#minimatch" - Hoisted from "gulp#glob-watcher#chokidar#fsevents#node-pre-gyp#npm-packlist#ignore-walk#minimatch" info Disk size without dependencies: "44KB" info Disk size with unique dependencies: "64KB" info Disk size with transitive dependencies: "120KB" info Number of shared dependencies: 1 => Found "browserify#minimatch@2.0.10" info Reasons this module exists - "gulp-browserify-thin#browserify#glob" depends on it - Hoisted from "gulp-browserify-thin#browserify#glob#minimatch" info Disk size without dependencies: "76KB" info Disk size with unique dependencies: "96KB" info Disk size with transitive dependencies: "152KB" info Number of shared dependencies: 1 ✨ Done in 0.96s. ``` **Test Plan** Check if `gulp-browserify-thin` is required anywhere, it is not. Pull Request resolved: facebookarchive/draft-js#2032 Reviewed By: mrkev Differential Revision: D14388097 Pulled By: mrkev fbshipit-source-id: 6b9b46ec8129d7899805021fbd6d6d1f8b9e443b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused dev dependency on
gulp-browserify-thin
. Addresses a security vulnerability that affectsminimatch@2.0.10
indirectly required through this module.Test Plan
Check if
gulp-browserify-thin
is required anywhere, it is not.