This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
adding-support-for-paragraph - making blockTypes configurable #205
Closed
mitermayer
wants to merge
13
commits into
facebookarchive:master
from
mitermayer:adding-support-for-paragraph
Closed
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
280a0fe
adding-support-for-paragraph - Adding paragraph to demo and to conver…
mitermayer 286fa89
adding-support-for-paragraph - Removing extra headers from rich.html …
mitermayer a442439
adding-support-for-paragraph - Fixing tests
mitermayer 49b3af8
making-inlinestyles-blockmap-links-extensible - Making Blocks extensible
mitermayer 810140e
adding-support-for-paragraph - Removing the paragraph option from the…
mitermayer 5c3b204
adding-support-for-paragraph - Removing rogue debugger
mitermayer 460420a
adding-support-for-paragraph - Fixing linting
mitermayer 28ff571
adding-support-for-paragraph - Tech review amends
mitermayer ce3a16b
Merge branch 'master' into adding-support-for-paragraph
mitermayer d8be3fa
adding-support-for-paragraph - tech review ammends
mitermayer 6d04824
adding-support-for-paragraph - Extra tech review amends
mitermayer e06c38a
adding-support-for-paragraph - updating example file
mitermayer 8ff93ac
adding-support-for-paragraph - Cosmetic changes
mitermayer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* Copyright (c) 2013-present, Facebook, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
* | ||
* @providesModule DraftBlockTag | ||
* @flow | ||
*/ | ||
|
||
'use strict'; | ||
|
||
/** | ||
* The list of default valid block tags. | ||
*/ | ||
export type DraftBlockTag = ( | ||
'div' | | ||
'p' | | ||
'h1' | | ||
'h2' | | ||
'h3' | | ||
'h4' | | ||
'h5' | | ||
'h6' | | ||
'li' | | ||
'blockquote' | | ||
'pre' | | ||
'figure' | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,6 @@ | |
*/ | ||
export type DraftBlockType = ( | ||
'unstyled' | | ||
'paragraph' | | ||
'header-one' | | ||
'header-two' | | ||
'header-three' | | ||
|
@@ -27,7 +26,6 @@ export type DraftBlockType = ( | |
'unordered-list-item' | | ||
'ordered-list-item' | | ||
'blockquote' | | ||
'pullquote' | | ||
'code-block' | | ||
'media' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Paragraph and pullquote were never used / referenced and were causing static type errors using flow. If any application requires it it can then use the configurable API to include it as demonstrated on the rich.html example file There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the rest of the imports are alphabetical order.