This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix flow by allowing optional chaining #2369
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
+1 |
awibox
approved these changes
Mar 30, 2020
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** Turns out the optional chaining PR (facebookarchive#2330) also broke flow. We should run a flow check automatically before we build, not just strip the types. **Test Plan** `flow .` Pull Request resolved: facebookarchive#2369 Reviewed By: claudiopro Differential Revision: D20680346 Pulled By: mrkev fbshipit-source-id: c30392a4e8084521c7e66f303fbc5f4832866e98
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Turns out the optional chaining PR (facebookarchive/draft-js#2330) also broke flow. We should run a flow check automatically before we build, not just strip the types. **Test Plan** `flow .` Pull Request resolved: facebookarchive/draft-js#2369 Reviewed By: claudiopro Differential Revision: D20680346 Pulled By: mrkev fbshipit-source-id: c30392a4e8084521c7e66f303fbc5f4832866e98
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Turns out the optional chaining PR (#2330) also broke flow. We should run a flow check automatically before we build, not just strip the types.
Test Plan
flow .