Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Update link to Record in docs #2418

Closed

Conversation

agarwalrounak
Copy link
Contributor

Summary
Record in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirects to https://immutable-js.github.io/immutable-js/

However, the correct link for Record is https://immutable-js.github.io/immutable-js/docs/#/Record

@NaviMarella
Copy link

@agarwalrounak Changes looks good to me. Thanks for your contribution 🎉

@mrkev
Copy link
Contributor

mrkev commented May 19, 2020

Draft.js uses immutable 3.7.x. We should link to the docs for that version, otherwise the'll be confusion.

https://github.com/facebook/draft-js/blob/268ece35025ecc280282a5169a0a4620f00e3371/package.json#L39

@agarwalrounak
Copy link
Contributor Author

Tuns out, there is no way to link to the older version of the docs. People have asked for old doc versions to be made available(here and here) but there seems to be no work towards that.

@mrkev
Copy link
Contributor

mrkev commented May 26, 2020

Hmm, I'd merge this PR if it linked to an old version of the docs through the Internet Archive. IMO it's the best option we have.

@agarwalrounak
Copy link
Contributor Author

Draft.js uses immutable 3.7.4 which released on 18 Jun 2015 according to this commit immutable-js/immutable-js@09f04e9
I have linked Record to an old version of the docs(captured on 23 Jun 2015) through the Internet Archive.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@claudiopro
Copy link
Contributor

Looks good to me, thank you both for converging towards a meaningful solution 👍

@facebook-github-bot
Copy link

@mrkev merged this pull request in 6a55c38.

alicayan008 pushed a commit to alicayan008/draft-js that referenced this pull request Jul 4, 2023
Summary:
**Summary**
Record in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirects to https://immutable-js.github.io/immutable-js/

However, the correct link for Record is https://immutable-js.github.io/immutable-js/docs/#/Record

Pull Request resolved: facebookarchive/draft-js#2418

Reviewed By: elboman, claudiopro

Differential Revision: D22785904

Pulled By: mrkev

fbshipit-source-id: 225dedb2198b7e11023c2aa7eed75901d7c558bf
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants