-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs/korean] Translate official document to Korean #18
Conversation
Hi @alstn2468! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks so much for providing this, this is awesome! My question is, since we're still changing the APIs and our docs are still being edited a lot, do we want to ship a translation that may fall out of date? Are you going to keep it up to date? |
I plan to keep it up to date. Recent changes have been reflected. |
TodoDocs to korean
Docusaurus i18n
|
docs/i18n/ko/docusaurus-plugin-content-docs/current/api-reference/core/Snapshot.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Asher Hwang <dev@hsh.kr>
번역 문서 전체적인 문체, 어투를 통일해주 실 분을 찾습니다!현재 여러 사람이 나누어 번역을 진행한 결과 -다, -니다 등 여러 문체가 섞여있는 것이 확인되었습니다! 최종적으로 번역되지 않은 문서는 |
@Mark-Yoo / @alstn2468 - #377 has now landed and we're hopefully ready to merge the Korean translation. However, it appears the branch currently has merge conflicts, perhaps due to #377? I think once that is resolved we can merge and publish these. |
@alstn2468, thanks for the rebase and I merged the PR. However, it seems broken. There's a missing |
@alstn2468 - That didn't seem to help, still getting the error: |
@drarmstr I had built by modifying the Path: |
Did the partial fix in #975. The manual edit seems to fix the build then. Seems suspicious, and anyone who deploys will have to remember to patch it, but at least we can deploy it now! |
@alstn2468 수고하셨습니다. 방금 한국어가 디플로이 된 걸 확인했네요. 위에서 말씀하신것처럼 어투 통일 및 몇몇 파일의 번역이 필요하겠네요. 틈틈히 저도 수정할 수 있도록 하겠습니다. https://github.com/javascript-tutorial/ko.javascript.info/wiki/번역-모범-사례 |
고생하셨습니다. |
안녕하세요, 이 풀리퀘를 못보고 installation 번역 풀리퀘를 올렸는데 따로 합쳐서 올리시던 중이셨나요?? |
@pumpkin-raccoon 안녕하세요~! 이미 한번 병합되어서 이제 문서 수정은 따로따로 pr올리셔도 괜찮을 것 같습니다! |
<RecoilRoot />