Adding Code of Conduct file #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@zeroxoneb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@zeroxoneb merged this pull request in 67f0568. |
facebook-github-bot
added a commit
to facebookarchive/buckit
that referenced
this pull request
Dec 4, 2019
Summary: This is pull request was created automatically because we noticed your project was missing a Code of Conduct file. Code of Conduct files facilitate respectful and constructive communities by establishing expected behaviors for project contributors. This PR was crafted with love by Facebook's Open Source Team. Pull Request resolved: facebookincubator/antlir#3 Test Plan: There's no real test plan here, it's just documentation. Differential Revision: D18812272 Pulled By: zeroxoneb fbshipit-source-id: cf6cc72748da1284296410d3e6bd4e0e92f8fbac
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
Summary: ... to simplify implementation of [floats in starlark-rust](facebook/starlark-rust#3). Pull Request resolved: facebookincubator/gazebo#3 Reviewed By: blackm00n Differential Revision: D30990124 Pulled By: ndmitchell fbshipit-source-id: c365e39f44eb86ce173d2b04247a98d848f689e3
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
Summary:
Having a default of 3 saves an _enormous_ amount of time when building btrfs loopback images. Most btrfs loopback targets are for tests and so don't need high compression, we should optimize for speed of builds instead. For the targets that ship into prod we can set this compression level appropriately on a case by case basis.
A single data point about build speed improvements can be seen from my devserver when building the base VM image: `//metalos/os/vm:base.btrfs`:
With the old default of max compression (turns out 15 is the highest that btrfs supports) it takes ~2 minutes to build just the loopback target:
```
]# buck build --show-output //metalos/os/vm:base.btrfs
Parsing buck files: finished in 1.0 sec
Creating action graph: finished in 17.9 sec
Downloading... 0/12 artifacts, 0.00 bytes, 100.0% cache miss (for updated rules)
Building... 05:18.1 min (99%) 8880/8881 jobs, 17/8881 updated
- //metalos/os/vm:base.btrfs... 02:22.8 min (running computing_output_hashes[9.4 sec])
//metalos/os/vm:base.btrfs buck-out/gen/aab7ed39/metalos/os/vm/base.btrfs/layer.btrfs
```
Run #1 with compression at `3` clocks in at 32 seconds:
```
]# buck build --show-output //metalos/os/vm:base.btrfs
Parsing buck files: finished in 1.1 sec
Creating action graph: finished in 18.4 sec
Building... 48.2 sec (99%) 146/147 jobs, 0/147 updated
- //metalos/os/vm:base.btrfs... 32.1 sec (running computing_output_hashes[8.8 sec])
//metalos/os/vm:base.btrfs buck-out/gen/aab7ed39/metalos/os/vm/base.btrfs/layer.btrfs
```
Run #2 with compression at `15` clocks in at ~2:05 minutes:
```
]# buck build --show-output //metalos/os/vm:base.btrfs
Parsing buck files: finished in 2.3 sec
Creating action graph: finished in 21.1 sec
Building... 02:18.5 min (99%) 142/143 jobs, 0/143 updated
- //metalos/os/vm:base.btrfs... 02:05.3 min (running computing_output_hashes[8.2 sec])
//metalos/os/vm:base.btrfs buck-out/gen/aab7ed39/metalos/os/vm/base.btrfs/layer.btrfs
```
Run #2 with compression at `3` clocks in at ~23.8 seconds:
```
]# buck build --show-output //metalos/os/vm:base.btrfs
Parsing buck files: finished in 0.9 sec
Creating action graph: finished in 14.5 sec
Building... 35.0 sec (99%) 142/143 jobs, 0/143 updated
- //metalos/os/vm:base.btrfs... 23.8 sec (preparing)
//metalos/os/vm:base.btrfs buck-out/gen/aab7ed39/metalos/os/vm/base.btrfs/layer.btrfs
```
Run #3 with compression at `15` clocks in at ~2:04 minutes:
```
]# buck build --show-output //metalos/os/vm:base.btrfs
Parsing buck files: finished in 1.8 sec
Creating action graph: finished in 17.0 sec
Downloading... 7/7 artifacts, 19.93 Kbytes, 0.0% cache miss (for updated rules)
Building... 04:32.5 min (99%) 8932/8933 jobs, 16/8933 updated
- //metalos/os/vm:base.btrfs... 02:04.8 min (running computing_output_hashes[8.1 sec])
//metalos/os/vm:base.btrfs buck-out/gen/aab7ed39/metalos/os/vm/base.btrfs/layer.btrfs
```
Run #3 with compression at `3` clocks in at ~28 seconds:
```
]# buck build --show-output //metalos/os/vm:base.btrfs
Parsing buck files: finished in 1.7 sec
Creating action graph: finished in 16.3 sec
Downloading... 7/7 artifacts, 19.95 Kbytes, 0.0% cache miss (for updated rules)
Building... 02:59.1 min (99%) 8932/8933 jobs, 16/8933 updated
- //metalos/os/vm:base.btrfs... 28.3 sec (running computing_output_hashes[7.9 sec])
//metalos/os/vm:base.btrfs buck-out/gen/aab7ed39/metalos/os/vm/base.btrfs/layer.btrfs
```
Additionally, this does a drive by cleanup of the `LoopbackVolume` and `BtrfsLoopbackVolume` classes to simply accept `label` and `compression_level` explicitly instead of via the `loopback_opts_t` type. This makes the interface clearer IMO since the `loobpack_opts_t` type is really just for package image to consume.
Reviewed By: snarkmaster
Differential Revision: D35440279
fbshipit-source-id: 759cda6dea2adca9de01a322472273894be999ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pull request was created automatically because we noticed your project was missing a Code of Conduct file.
Code of Conduct files facilitate respectful and constructive communities by establishing expected behaviors for project contributors.
This PR was crafted with love by Facebook's Open Source Team.