Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cgroupfs: Add Pids controller #8215

Closed
wants to merge 1 commit into from
Closed

cgroupfs: Add Pids controller #8215

wants to merge 1 commit into from

Conversation

ton31337
Copy link
Contributor

@ton31337 ton31337 commented Dec 9, 2023 •
edited
Loading

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @ton31337!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@ton31337 ton31337 force-pushed the feature/add_pids_controller branch from f184eed to c2287b9 Compare December 9, 2023 10:50
@brianc118
Copy link
Contributor

Hi @ton31337 thanks for this, but before proceeding, can you please sign the CLA? Thanks!

brianc118
brianc118 suggested changes Dec 9, 2023
View reviewed changes
below/dump/src/command.rs Outdated Show resolved Hide resolved
below/model/src/cgroup.rs Show resolved Hide resolved
below/cgroupfs/src/types.rs Outdated Show resolved Hide resolved
below/render/src/default_configs.rs Outdated Show resolved Hide resolved
below/view/src/cgroup_view.rs Outdated Show resolved Hide resolved
below/model/src/cgroup.rs Outdated Show resolved Hide resolved
below/model/src/cgroup.rs Outdated Show resolved Hide resolved
below/render/src/default_configs.rs Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2023
@ton31337 ton31337 force-pushed the feature/add_pids_controller branch from c2287b9 to 814f192 Compare December 9, 2023 18:39
@ton31337
Copy link
Contributor Author

ton31337 commented Dec 9, 2023

@brianc118 thanks for a quick review.

@ton31337 ton31337 force-pushed the feature/add_pids_controller branch from 814f192 to fbdb202 Compare December 11, 2023 08:58
@ton31337 ton31337 requested a review from brianc118 December 11, 2023 15:01
@ton31337 ton31337 force-pushed the feature/add_pids_controller branch from fbdb202 to 06c21b7 Compare December 11, 2023 20:26
@facebook-github-bot
Copy link
Contributor

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

brianc118
brianc118 suggested changes Dec 11, 2023
View reviewed changes
below/view/src/cgroup_tabs.rs Outdated Show resolved Hide resolved
@brianc118
Copy link
Contributor

You will also need to fix the tests

@ton31337 ton31337 force-pushed the feature/add_pids_controller branch 2 times, most recently from 477f507 to da3859c Compare December 12, 2023 07:11
@ton31337
Copy link
Contributor Author

You will also need to fix the tests

Should be fine now, sorry.

@facebook-github-bot
Copy link
Contributor

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ton31337
Copy link
Contributor Author

Can I see what is missing from Linter?

@ton31337
cgroupfs: Add Pids controller
2c7dd03 
```
[
  {
    "Name": "<root>",
    "Tids Current": "?",
    "Tids Max": "?",
    "children": [
      {
        "Name": "dev-hugepages.mount",
        "Tids Current": "0",
        "Tids Max": "308848",
        "children": []
      },
      {
        "Name": "dev-mqueue.mount",
        "Tids Current": "0",
        "Tids Max": "308848",
        "children": []
      },
      {
        "Name": "init.scope",
        "Tids Current": "1",
        "Tids Max": "308848",
        "children": []
      },
      {
        "Name": "mysql",
        "Tids Current": "0",
        "Tids Max": "-1",
        "children": [
          {
            "Name": "u000000002_a",
            "Tids Current": "?",
            "Tids Max": "?",
            "children": []
          },
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337 ton31337 force-pushed the feature/add_pids_controller branch from da3859c to 2c7dd03 Compare December 13, 2023 11:53
@brianc118
Copy link
Contributor

Don't worry about the lints, when I merge, I'll apply the lint changes

@facebook-github-bot
Copy link
Contributor

@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@brianc118 merged this pull request in 1654f18.

@ton31337 ton31337 deleted the feature/add_pids_controller branch December 14, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianc118 brianc118 brianc118 requested changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ton31337 @facebook-github-bot @brianc118