Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: debugging in WebStorm #2986

Merged
merged 3 commits into from
Aug 21, 2017
Merged

Docs: debugging in WebStorm #2986

merged 3 commits into from
Aug 21, 2017

Conversation

prigara
Copy link
Contributor

@prigara prigara commented Aug 21, 2017

Hi!

I've added the steps for debugging the app in WebStorm (similar to VS Code).
Please let me know if you have any questions or I can improve something.
Thanks!

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@Timer
Copy link
Contributor

Timer commented Aug 21, 2017 •
edited
Loading

Should we add a note that their port may be different if they've configured it?

Other than that, this seems good to me!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@prigara
Copy link
Contributor Author

prigara commented Aug 21, 2017 •
edited
Loading

@Timer might be helpful. You can edit the port only if the app was ejected or you've set different environment variables, right?

@Timer
Copy link
Contributor

Timer commented Aug 21, 2017

Yup! I don't think we need to mention ejecting here, though.

I'd imagine the note would go something like this:

Note: The URL provided is the default. You may need to modify the URL if you've made adjustments via the HOST or PORT environment variables.

@prigara
Copy link
Contributor Author

prigara commented Aug 21, 2017

Done. Added 2 notes: for VS Code and for WebStorm. I think it's better that way - you won't miss it if you're reading only the editor-specific part.

@Timer Timer added this to the 1.0.12 milestone Aug 21, 2017
@Timer
Copy link
Contributor

Timer commented Aug 21, 2017

Perfect, thanks so much! 😄

@Timer Timer merged commit 5ea6de9 into facebook:master Aug 21, 2017
chrisportela added a commit to peopleticker/create-react-app that referenced this pull request Aug 22, 2017
@chrisportela
Merge pull request #4 from facebookincubator/master
b1592de 
Docs: debugging in WebStorm (facebook#2986)
@gaearon gaearon mentioned this pull request Aug 28, 2017
Merged
matart15 pushed a commit to matart15/create-react-app that referenced this pull request Aug 29, 2017
Merge branch 'master' of https://github.com/facebookincubator/create-…
bdc1366 
…react-app

* 'master' of https://github.com/facebookincubator/create-react-app: (36 commits)
  Publish
  Changelog for 1.0.12 (facebook#3016)
  Relax React dep requirements
  Default Favicon lossless optimisation (facebook#2917)
  update babel-runtime dependency in react-error-overlay and react-scripts (facebook#2991)
  Convert react-error-overlay to React (facebook#2515)
  Bump react-dev-utils
  Fix module function name in error overlay (facebook#3012)
  Docs: debugging in WebStorm (facebook#2986)
  Fix docs for `printFileSizesAfterBuild` (facebook#2942)
  Remove Modulus from user guide (facebook#2948)
  Remove superfluous lodash usage (facebook#2938)
  Update README.md (facebook#2927)
  Publish
  Prepare for 1.0.11 release (facebook#2924)
  Update dev deps (facebook#2923)
  Update README.md
  Use env variable to disable source maps (facebook#2818)
  Make formatWebpackMessages return all messages (facebook#2834)
  Adjust the `checkIfOnline` check if in a corporate proxy environment (facebook#2884)
  ...
gaearon added a commit that referenced this pull request Sep 2, 2017
@gaearon
Changelog for 1.0.13
e4694ab 
## 1.0.13 (September 2, 2017)

#### 🐛 Bug Fix

* `react-error-overlay`

  * [#3051](#3051) Fix case-sensitivity issue with upgrading the package version. ([@tharakawj](https://github.com/tharakawj))

* `react-dev-utils`

  * [#3049](#3049) Print filesize difference for chunks. ([@esturcke](https://github.com/esturcke))

* `react-scripts`

  * [#3046](#3046) Fix crash in development mode on IE11. ([@tharakawj](https://github.com/tharakawj))

#### 💅 Enhancement

* `react-scripts`

  * [#3033](#3033) Add an empty mock for `child_process` to let some libraries compile. ([@McFlurriez](https://github.com/McFlurriez))

#### 🏠 Internal

* `react-dev-utils`, `react-error-overlay`

  * [#3028](#3028) Make error overlay filename configurable. ([@jaredpalmer](https://github.com/jaredpalmer))

#### Committers: 4

- Anthony ([McFlurriez](https://github.com/McFlurriez))
- Erik J. Sturcke ([esturcke](https://github.com/esturcke))
- Jared Palmer ([jaredpalmer](https://github.com/jaredpalmer))
- Tharaka Wijebandara ([tharakawj](https://github.com/tharakawj))

### Migrating from 1.0.12 to 1.0.13

Inside any created project that has not been ejected, run:

```
npm install --save --save-exact react-scripts@1.0.13
```

or

```
yarn add --exact react-scripts@1.0.13
```

## 1.0.12 (August 28, 2017)

#### 🐛 Bug Fix

* `react-error-overlay`
  * [#3012](#3012) Fix module function name in error overlay. ([@gaearon](https://github.com/gaearon))

* `react-dev-utils`
  * [#2938](#2938) Remove superfluous lodash usage. ([@Timer](https://github.com/Timer))

#### 💅 Enhancement

* `react-scripts`

  * [#2917](#2917) Optimize the size of default favicon. ([@sylvainbaronnet](https://github.com/sylvainbaronnet))

#### 📝 Documentation

* `react-scripts`

  * [#2986](#2986) Docs: debugging in WebStorm. ([@prigara](https://github.com/prigara))
  * [#2948](#2948) Remove Modulus from user guide. ([@Zertz](https://github.com/Zertz))
  * [#2927](#2927) Update README.md. ([@tbassetto](https://github.com/tbassetto))

* `react-dev-utils`

  * [#2942](#2942) Fix docs for `printFileSizesAfterBuild`. ([@Kerumen](https://github.com/Kerumen))

#### 🏠 Internal

* `react-error-overlay`, `react-scripts`

  * [#2991](#2991) Update `babel-runtime` dependency ([@christophehurpeau](https://github.com/christophehurpeau))

* `react-dev-utils`, `react-error-overlay`, `react-scripts`

  * [#2515](#2515) Convert `react-error-overlay` to React ([@tharakawj](https://github.com/tharakawj))

#### Committers: 9

- Christophe Hurpeau ([christophehurpeau](https://github.com/christophehurpeau))
- Dan Abramov ([gaearon](https://github.com/gaearon))
- Ekaterina Prigara ([prigara](https://github.com/prigara))
- Joe Haddad ([Timer](https://github.com/Timer))
- Pier-Luc Gendreau ([Zertz](https://github.com/Zertz))
- Sylvain Baronnet ([sylvainbaronnet](https://github.com/sylvainbaronnet))
- Tharaka Wijebandara ([tharakawj](https://github.com/tharakawj))
- Thomas Bassetto ([tbassetto](https://github.com/tbassetto))
- Yann Pringault ([Kerumen](https://github.com/Kerumen))

### Migrating from 1.0.11 to 1.0.12

Inside any created project that has not been ejected, run:

```
npm install --save --save-exact react-scripts@1.0.12
```

or

```
yarn add --exact react-scripts@1.0.12
```

**Note:** there’s a [known issue](#3041) that might cause the project to not compile after upgrading. In this case, migrate straight to `1.0.13` which doesn’t have this issue.
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017
@prigara @JohnNilsson
Docs: debugging in WebStorm (#2986)
7aa5c2c 
* Debugging in WebStorm

* Fixed formatting for shortcuts

* Added note about default URL
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
@prigara @thongdong7
Docs: debugging in WebStorm (facebook#2986)
9af1b83 
* Debugging in WebStorm

* Fixed formatting for shortcuts

* Added note about default URL
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this pull request Sep 24, 2017
@prigara @thongdong7
Docs: debugging in WebStorm (facebook#2986)
89f7a26 
* Debugging in WebStorm

* Fixed formatting for shortcuts

* Added note about default URL
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
@prigara @kasperpeulen
Docs: debugging in WebStorm (facebook#2986)
59544f0 
* Debugging in WebStorm

* Fixed formatting for shortcuts

* Added note about default URL
swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017
@prigara @swengorschewski
Docs: debugging in WebStorm (#2986)
a3329e8 
* Debugging in WebStorm

* Fixed formatting for shortcuts

* Added note about default URL
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
1.0.12
Development

Successfully merging this pull request may close these issues.
3 participants
@prigara @facebook-github-bot @Timer