Auto-detect running editor on Linux for error overlay #3077

gulderov · 2017-09-06T12:12:37Z

Basic support of auto detecting running editor for #2636.
Tested on Ubuntu 16.04.
It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor.

Basic support of auto detecting running editor for #2636. Tested on Ubuntu 16.04. It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor.

facebook-github-bot · 2017-09-06T12:12:43Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot · 2017-09-06T12:18:44Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Timer · 2017-09-06T13:01:43Z

😍 this is great!

Timer · 2017-09-06T13:03:27Z

packages/react-dev-utils/launchEditor.js

@@ -145,7 +157,6 @@ function guessEditor() {
  }

  // Using `ps x` on OSX or `Get-Process` on Windows we can find out which editor is currently running.


Maybe we can update this now, too.

Using ps on macOS/Linux or Get-Process on Windows ...

reworded it

Timer · 2017-09-06T13:03:44Z

packages/react-dev-utils/launchEditor.js

@@ -176,6 +187,17 @@ function guessEditor() {
          return [fullProcessPath];
        }
      }
+    } else if (process.platform === 'linux') {
+      const output = child_process
+        .execSync('ps --no-heading -e -o comm --sort=comm')


Could we explain the significance of these flags?

put some comment

Timer · 2017-09-06T13:05:19Z

packages/react-dev-utils/launchEditor.js

+      const processNames = Object.keys(COMMON_EDITORS_LINUX);
+      for (let i = 0; i < processNames.length; i++) {
+        const processName = processNames[i];
+        if (output.indexOf(processName) !== -1) {


Should we worry about a process which is named like, mycode or something matching code?
Can we make sure it's delimited/a whole word?

We'd probably want to apply this logic to macOS, too.
Not sure if you have a macOS box so we could do this in a separate PR.

I am not sure. processNames under our control. ps -o comm output looks nice. It show

command name (only the executable name). Modifications to the command name will not be shown. A process marked <defunct> is partly dead, waiting to be fully destroyed by its parent. The output in this column may contain spaces. (alias ucmd, ucomm). See also the args format keyword, the -f option, and the c option.

in list like:

kworker/u8:3 led_workqueue lightdm

We can worry about it later. 😄

Timer · 2017-09-10T16:08:33Z

packages/react-dev-utils/launchEditor.js

+  // We can find out which editor is currently running by:
+  // `ps x` on OSX
+  // `Get-Process` on Windows
+  // `ps -e` on Linux


I assume this should be updated to say ps x? Or update above comment to say:

ps x on macOS and Linux

(please make the change from OSX to macOS)

Timer · 2017-09-10T16:09:27Z

Could you please merge/rebase this? I'd like to land it shortly after.
Thanks!

# Conflicts: # packages/react-dev-utils/launchEditor.js

gulderov · 2017-09-11T08:46:52Z

Merged with current master

Timer · 2017-09-11T12:31:14Z

Great, thanks!
I did some basic testing [that the command on ubuntu-server] but I trust you that this works. 😄

…react-app * 'master' of https://github.com/facebookincubator/create-react-app: Resolved issue facebook#2971 (facebook#2989) Revert "run npm 5.4.0 in CI (facebook#3026)" (facebook#3107) Updated react-error-overlay to latest Flow (0.54.0) (facebook#3065) Auto-detect running editor on Linux for error overlay (facebook#3077) Clean target directory before compiling overlay (facebook#3102) Rerun prettier and pin version (facebook#3058) Reload the page when an error has occurred (facebook#3098) run npm 5.4.0 in CI (facebook#3026) Unmapper Windows compatibility (facebook#3079) Update eslint-config npm install command (facebook#3072) Set travis config to use 'precise' ci environment Publish Changelog for 1.0.13 Add missing slash Make error overlay filename configurable (facebook#3028) provide empty mock for child_process so importing libraries with it works (facebook#3033) Rename Overlay to ErrorOvelay (facebook#3051) Strip hash from chunk file name (facebook#3049) Fix error overlay 'Object.assign' issue in IE by including polyfills before webpack client (facebook#3046)

* Auto-detect running editor on Linux for error overlay Basic support of auto detecting running editor for facebook#2636. Tested on Ubuntu 16.04. It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor. * Comments fixed. * List all processes owned by you * Comment rewording

…pescript * 'master' of https://github.com/wmonk/create-react-app-typescript: (265 commits) fix typo in changelog Update README For 2.13.0 v2.13.0 Remove tslint-loader from prod build (again) Include TypeScript as devDependency in boilerplate output Documented how to define custom module formats for the TypeScript compiler so that you can import images and other files (references wmonk#172) v2.12.0 Update README For 2.12.0 Update typescript to 2.6.2 v2.11.0 Update changelog for 2.11.0 Fixed problem with tsconfig.json baseUrl and paths Update createJestConfig.js Update changelog for 2.10.0 v2.10.0 Readd transformIgnorePatterns Update react-dev-utils Update package.json dependencies Readd Missing raf Package Update JestConfig Creation Fix Fix Missing Variable Fix package.json Merge pull request wmonk#204 from StefanSchoof/patch-1 Merge pull request wmonk#201 from StefanSchoof/patch-1 Merge pull request wmonk#199 from DorianGrey/master Merge pull request wmonk#165 from johnnyreilly/master Publish Add 1.0.17 changelog (#3402) Use new WebpackDevServer option (#3401) Fix grammar in README (#3394) Add link to VS Code troubleshooting guide (#3399) Update VS Code debug configuration (#3400) Update README.md (#3392) Publish Reorder publishing instructions Changelog for 1.0.16 (#3376) Update favicon description (#3374) Changelog for 1.0.15 (#3357) Replace template literal; fixes #3367 (#3368) CLI@1.4.2 Publish Add preflight CWD check for npm (#3355) Stop using `npm link` in tests (#3345) Fix for add .gitattributes file #3080 (#3122) Mention that start_url needs to be "." for client side routing start using npm-run-all to build scss and js (#2957) Updating the Service Worker opt-out documentation (#3108) Remove an useless negation in registerServiceWorker.js (#3150) Remove output.path from dev webpack config (#3158) Add `.mjs` support (#3239) Add documentation for Enzyme 3 integration (#3286) Make uglify work in Safari 10.0 - fixes #3280 (#3281) Fix favicon sizes value in manifest (#3287) Bump dependencies (#3342) recommend react-snap; react-snapshot isn't upgraded for React 16 (#3328) Update appveyor.cleanup-cache.txt Polyfill rAF in test environment (#3340) Use React 16 in development Use a simpler string replacement for the overlay Clarify the npm precompilation advice --no-edit Update `eslint-plugin-react` (#3146) Add jest coverage configuration docs (#3279) Update link to Jest Expect docs (#3303) Update README.md Fix dead link to Jest "expect" docs (#3289) v2.8.0 Use production React version for bundled overlay (#3267) Add warning when using `react-error-overlay` in production (#3264) Add external links to deployment services (#3265) `react-error-overlay` has no dependencies now (#3263) Add click-to-open support for build errors (#3100) Update style-loader and disable inclusion of its HMR code in builds (#3236) Update url-loader to 0.6.2 for mime ReDoS vuln (#3246) Make error overlay to run in the context of the iframe (#3142) Upgrade to typescript 2.5.3 Fix Windows compatibility (#3232) Fix package management link in README (#3227) Watch for changes in `src/**/node_modules` (#3230) More spec compliant HTML template (#2914) Minor change to highlight dev proxy behaviour (#3075) Correct manual proxy documentation (#3185) Improve grammar in README (#3211) Publish Fix license comments Changelog for 1.0.14 BSD+Patents -> MIT (#3189) Add link to active CSS modules discussion (#3163) Update webpack-dev-server to 2.8.2 (#3157) Part of class fields to stage 3 (#2908) Update unclear wording in webpack config docs (#3160) Display pid in already running message (#3131) Link local react-error-overlay package in kitchensink test Resolved issue #2971 (#2989) Revert "run npm 5.4.0 in CI (#3026)" (#3107) Updated react-error-overlay to latest Flow (0.54.0) (#3065) Auto-detect running editor on Linux for error overlay (#3077) Clean target directory before compiling overlay (#3102) Rerun prettier and pin version (#3058) ...

Auto-detect running editor on Linux for error overlay

64a6ed7

Basic support of auto detecting running editor for #2636. Tested on Ubuntu 16.04. It detects few editors. JetBrains products should start by wrapper like /usr/local/bin/webstorm. Otherwise it takes a lot of time to open editor.

facebook-github-bot added the CLA Signed label Sep 6, 2017

Timer added the tag: enhancement label Sep 6, 2017

Timer added this to the 1.0.13 milestone Sep 6, 2017

Timer reviewed Sep 6, 2017

View reviewed changes

gulderov added 2 commits September 7, 2017 14:07

Comments fixed.

992104c

List all processes owned by you

9456669

Timer reviewed Sep 10, 2017

View reviewed changes

gulderov added 2 commits September 11, 2017 11:29

Comment rewording

9197752

Merge branch 'master' into auto-detect-editor-linux

e023800

# Conflicts: # packages/react-dev-utils/launchEditor.js

Timer merged commit 1faee66 into facebook:master Sep 11, 2017

gulderov deleted the auto-detect-editor-linux branch September 11, 2017 12:47

lock bot locked and limited conversation to collaborators Jan 20, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-detect running editor on Linux for error overlay #3077

Auto-detect running editor on Linux for error overlay #3077

gulderov commented Sep 6, 2017

facebook-github-bot commented Sep 6, 2017

facebook-github-bot commented Sep 6, 2017

Timer commented Sep 6, 2017

Timer Sep 6, 2017

gulderov Sep 7, 2017

Timer Sep 6, 2017

gulderov Sep 7, 2017

Timer Sep 6, 2017

Timer Sep 6, 2017

gulderov Sep 7, 2017 •

edited

Loading

Timer Sep 10, 2017

Timer Sep 10, 2017 •

edited

Loading

gulderov Sep 11, 2017

Timer commented Sep 10, 2017 •

edited

Loading

gulderov commented Sep 11, 2017

Timer commented Sep 11, 2017

		@@ -145,7 +157,6 @@ function guessEditor() {
		}

		// Using `ps x` on OSX or `Get-Process` on Windows we can find out which editor is currently running.

Auto-detect running editor on Linux for error overlay #3077

Auto-detect running editor on Linux for error overlay #3077

Conversation

gulderov commented Sep 6, 2017

facebook-github-bot commented Sep 6, 2017

facebook-github-bot commented Sep 6, 2017

Timer commented Sep 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gulderov Sep 7, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Timer Sep 10, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Timer commented Sep 10, 2017 • edited Loading

gulderov commented Sep 11, 2017

Timer commented Sep 11, 2017

gulderov Sep 7, 2017 •

edited

Loading

Timer Sep 10, 2017 •

edited

Loading

Timer commented Sep 10, 2017 •

edited

Loading