Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document adding a router #3709

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Document adding a router #3709

merged 1 commit into from
Jan 8, 2018

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jan 8, 2018

What it says.

@gaearon gaearon added this to the 1.0.18 milestone Jan 8, 2018
@gaearon gaearon merged commit bb71830 into master Jan 8, 2018
@gaearon gaearon mentioned this pull request Jan 8, 2018
Closed
@Timer Timer deleted the gaearon-patch-1 branch January 8, 2018 14:06
@Timer
Copy link
Contributor

Timer commented Jan 8, 2018

I'm pretty sure it's only mandatory to install react-router-dom, installing react-router alongside react-router-dom is extraneous.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 8, 2018

Ah you're right.

@gaearon gaearon mentioned this pull request Jan 15, 2018
Merged
@dependencies dependencies bot mentioned this pull request Jan 15, 2018
Merged
This was referenced Feb 2, 2018
Open
Closed
Closed
Closed
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
@gaearon
Document adding a router (facebook#3709)
e130293
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
@gaearon
Document adding a router (facebook#3709)
19bc816
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @Timer @facebook-github-bot