Support setting none in REACT_EDITOR env variable #3721
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
| @@ -257,6 +257,11 @@ function launchEditor(fileName, lineNumber) { | |||
| } | |||
|
|
|||
| let [editor, ...args] = guessEditor(); | |||
|
|
|||
| if (editor.toLowerCase() === 'none') { | |||
There was a problem hiding this comment.
it's ok if i just modify the condition? editor && editor.toLowerCase() === 'none'
There was a problem hiding this comment.
We could just move this condition after the next one.
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Instead of an extra check let's just move the condition down? |
|
Done! thanks for your help |
* add support to set REACT_EDITOR to none * change README message * change condition to avoid problems with editor being null * move condition to avoid extra code
* add support to set REACT_EDITOR to none * change README message * change condition to avoid problems with editor being null * move condition to avoid extra code
This aims to solve #3706
I updated the README to indicate that you can set REACT_EDITOR to none in order to avoid opening the text editor automatically.