Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix InterpolateHtmlPlugin only replacing the first occurrence #731

Merged
merged 1 commit into from
Sep 23, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Sep 23, 2016

@ghost ghost added the CLA Signed label Sep 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Verified on an example input?

@fson
Copy link
Contributor Author

fson commented Sep 23, 2016

Verified that

    <link href="%PUBLIC_URL%/pace/theme/pace-theme-minimal.css" rel="stylesheet" />
    <script type="text/javascript">
      paceOptions = {ajax: {trackWebSockets: false}};
    </script>
    <script src="%PUBLIC_URL%/pace/pace.js"></script>

gets converted to

    <link href="/pace/theme/pace-theme-minimal.css" rel="stylesheet" />
    <script type="text/javascript">
      paceOptions = {ajax: {trackWebSockets: false}};
    </script>
    <script src="/pace/pace.js"></script>

in the HTML served by the development server.

@fson
Copy link
Contributor Author

fson commented Sep 23, 2016

And checked that all occurrences of %PUBLIC_URL% get replaced with the path from homepage in the production build.

@gaearon gaearon added this to the 0.5.1 milestone Sep 23, 2016
@gaearon gaearon merged commit e41d671 into facebook:master Sep 23, 2016
@gaearon
Copy link
Contributor

gaearon commented Sep 23, 2016

Thanks

@fson fson deleted the fix-interpolation branch September 23, 2016 23:33
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants