Disable broken test (#113)

Summary:
Pull Request resolved: #113

See comment

Reviewed By: phlalx

Differential Revision: D47334480

fbshipit-source-id: abc9646194fb6652fa990ff89a443b63d89f9cb9

.github/workflows/ci-getdeps.yml

@@ -60,5 +60,5 @@ jobs:
         run: cabal build all
         working-directory: ./_sdists
       - name: Run testsuites
-        run: cabal test mangle fb-util thrift-compiler thrift-lib thrift-cpp-channel thrift-server thrift-tests --keep-going
+        run: cabal test mangle fb-util thrift-compiler thrift-lib thrift-server thrift-tests --keep-going
         working-directory: ./_sdists

cpp-channel/thrift-cpp-channel.cabal

@@ -132,6 +132,11 @@ flag tests_use_ipv4
      default: False
      manual: True
 
+flag include_broken_tests
+     description: Include broken tests
+     default: False
+     manual: True
+
 test-suite header-channel
   import: fb-haskell, fb-cpp
   type: exitcode-stdio-1.0
@@ -144,8 +149,8 @@ test-suite header-channel
                test/if/gen-cpp2/Calculator.cpp
                test/if/gen-cpp2/AdderAsyncClient.cpp
                test/if/gen-cpp2/Adder.cpp
-               test/if/gen-cpp2/math_data.cpp
                test/if/gen-cpp2/math_types.cpp
+               test/if/gen-cpp2/math_data.cpp
                test/if/gen-cpp2/math_metadata.cpp
   extra-libraries:
         thriftmetadata
@@ -177,3 +182,14 @@ test-suite header-channel
                   unordered-containers,
                   deepseq,
                   STMonadTrans
+
+  -- This test is broken when built from github. For some reason the
+  -- requests timeout. It seems to be a subtle timing issue of some
+  -- kind inside fbthrift, because I tried tracing through the code
+  -- using gdb and when using breakpoints the test will sometimes
+  -- pass. Without a deeper understanding of the internals of fbthrift
+  -- I can't get any further, so just ignoring the test for now. It
+  -- passes on the internal CI so I'm pretty sure it's not an issue
+  -- with the test itself.
+  if !flag(include_broken_tests)
+     buildable: False