Skip to content

Commit

Permalink
Fix github CI (#470)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebookincubator/Glean#470

Reviewed By: malanka

Differential Revision: D62227838

fbshipit-source-id: 01802dd992322466e433a05cbb63c3169a22e014
  • Loading branch information
Simon Marlow authored and facebook-github-bot committed Sep 5, 2024
1 parent d89ab87 commit b6031a6
Show file tree
Hide file tree
Showing 4 changed files with 23 additions and 3 deletions.
7 changes: 6 additions & 1 deletion common/util/fb-util.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ common fb-haskell
ghc-options: -O2

common fb-cpp
cxx-options: -std=c++17 -fcoroutines
cxx-options: -std=c++17
if !flag(clang)
cxx-options: -fcoroutines
if arch(x86_64)
cxx-options: -march=haswell
if flag(opt)
Expand All @@ -69,6 +71,9 @@ common fb-cpp
flag opt
default: False

flag clang
default: False

library
import: fb-haskell, fb-cpp

Expand Down
7 changes: 6 additions & 1 deletion cpp-channel/thrift-cpp-channel.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ common fb-haskell
ghc-options: -O2

common fb-cpp
cxx-options: -std=c++17 -fcoroutines
cxx-options: -std=c++17
if !flag(clang)
cxx-options: -fcoroutines
if arch(x86_64)
cxx-options: -march=haswell
if flag(opt)
Expand All @@ -75,6 +77,9 @@ common fb-cpp
flag opt
default: False

flag clang
default: False

library
import: fb-haskell, fb-cpp
exposed-modules:
Expand Down
7 changes: 6 additions & 1 deletion server/thrift-server.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ common fb-haskell
ghc-options: -O2

common fb-cpp
cxx-options: -std=c++17 -fcoroutines
cxx-options: -std=c++17
if !flag(clang)
cxx-options: -fcoroutines
-- very important to use -fcoroutines here, because there are
-- #ifdefs in the fbthrift code (e.g. ThriftServer.h) that must
-- be consistent with the fbthrift build.
Expand All @@ -73,6 +75,9 @@ common fb-cpp
flag opt
default: False

flag clang
default: False

library
import: fb-haskell, fb-cpp
exposed-modules:
Expand Down
5 changes: 5 additions & 0 deletions tests/thrift-tests.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,14 @@ common fb-haskell

common fb-cpp
cxx-options: -std=c++17
if !flag(clang)
cxx-options: -fcoroutines
if arch(x86_64)
cxx-options: -march=haswell

flag clang
default: False

common test-common
hs-source-dirs: ., gen-hs2/
build-depends: aeson,
Expand Down

0 comments on commit b6031a6

Please sign in to comment.