Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use button instead of div for navbar toggle button #64

Merged
merged 1 commit into from
Feb 14, 2021
Merged

fix: use button instead of div for navbar toggle button #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/demo/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<div class="container">
<div class="navbar__inner">
<div class="navbar__items">
<div class="navbar__toggle" role="button">
<button class="navbar__toggle" type="button">
<svg
xmlns="http://www.w3.org/2000/svg"
width="30"
Expand All @@ -90,7 +90,7 @@
d="M4 7h22M4 15h22M4 23h22"
></path>
</svg>
</div>
</button>
<a class="navbar__brand" href="#">
<img
class="navbar__logo"
Expand Down
3 changes: 3 additions & 0 deletions packages/core/styles/components/navbar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@
cursor: pointer;
display: none;
margin-right: 0.5rem;
border: 0;
background: 0 0;
Copy link
Contributor

@Simek Simek Feb 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the goal here was to reset the background position the background-position property should be used.

If the goal was to remove background completely using none is recommended over 0 and the second 0 is redundant.

padding: 0;

@media (--ifm-narrow-window) {
display: inherit;
Expand Down