Fix the incorrect size calculation logic of FileSink.

facebookincubator · Apr 11, 2024 · a18128e · a18128e
1 parent 5863b08
commit a18128e
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/velox/dwio/common/tests/MemorySinkTest.cpp b/velox/dwio/common/tests/MemorySinkTest.cpp
@@ -34,15 +34,13 @@ TEST_F(MemorySinkTest, create) {
   std::string chars("abcdefghijklmnopqrst");
   std::vector<DataBuffer<char>> buffers;
 
+  // Add 'abcdefghij' to first buffer
   buffers.emplace_back(*pool_);
-  for (auto i = 0; i < 10; ++i) {
-    buffers.back().append(chars[i]);
-  }
+  buffers.back().append(0, chars.data(), 10);
 
+  // Add 'klmnopqrst' to second buffer
   buffers.emplace_back(*pool_);
-  for (auto i = 10; i < chars.length(); ++i) {
-    buffers.back().append(chars[i]);
-  }
+  buffers.back().append(0, chars.data() + 10, 10);
 
   ASSERT_EQ(buffers.size(), 2);