Guard metrics upload and report generation for fork PRs #10080
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
approved these changes
Jun 6, 2024
majetideepak
added
the
ready-to-merge
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kevinwilfong merged this pull request in ff07cb0. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
deepashreeraghu
pushed a commit
to deepashreeraghu/velox
that referenced
this pull request
Jun 13, 2024
…bator#10080) Summary: I noticed in facebookincubator#9903 that the upload errors due to missing credentials. This PR adds a guard that allows the job to finish ✔️ even from a fork. It will still run the upload (for testing) when the PR is from within the main repo. Pull Request resolved: facebookincubator#10080 Reviewed By: bikramSingh91 Differential Revision: D58244591 Pulled By: kevinwilfong fbshipit-source-id: e75bf84292ad046dfc85be9f1a3b813af474cf11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in #9903 that the upload errors due to missing credentials. This PR adds a guard that allows the job to finish ✔️ even from a fork. It will still run the upload (for testing) when the PR is from within the main repo.