Measure isBlocked and isFinished operator calls #10923
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
yingsu00
force-pushed
the
isBlockedTime
branch
from
62e0f60
to
8b457e7
Compare
yingsu00
force-pushed
the
isBlockedTime
branch
2 times, most recently
from
34d307d
to
53f061a
Compare
|
@Yuhta @xiaoxmeng Can you please review this? Thanks! |
Yuhta
reviewed
Sep 25, 2024
| @@ -1184,7 +1184,7 @@ DEBUG_ONLY_TEST_F(TaskTest, liveStats) { | |||
| EXPECT_EQ(32 * numBatches, operatorStats.outputBytes); | |||
| EXPECT_EQ(3 * numBatches, operatorStats.outputPositions); | |||
| EXPECT_EQ(numBatches, operatorStats.outputVectors); | |||
| EXPECT_EQ(1, operatorStats.finishTiming.count); | |||
| EXPECT_EQ(2, operatorStats.finishTiming.count); | |||
There was a problem hiding this comment.
Is there a way to check isBlockedTiming e.g. in HashProbe?
There was a problem hiding this comment.
yes. I just added it to this test.
for (auto i = 0; i < numBatches; ++i) {
...
EXPECT_EQ(2 * (i + 1), operatorStats.isBlockedTiming.count);
Sorry I didn't add it until now. I was blocked by the build issues for a long time.
yingsu00
force-pushed
the
isBlockedTime
branch
2 times, most recently
from
9e68cc9
to
1f1285f
Compare
xiaoxmeng
approved these changes
Sep 30, 2024
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
velox/exec/tests/TaskTest.cpp
Outdated
| @@ -1184,7 +1185,8 @@ DEBUG_ONLY_TEST_F(TaskTest, liveStats) { | |||
| EXPECT_EQ(32 * numBatches, operatorStats.outputBytes); | |||
| EXPECT_EQ(3 * numBatches, operatorStats.outputPositions); | |||
| EXPECT_EQ(numBatches, operatorStats.outputVectors); | |||
| EXPECT_EQ(1, operatorStats.finishTiming.count); | |||
| EXPECT_EQ(2 * numBatches, operatorStats.isBlockedTiming.count); | |||
There was a problem hiding this comment.
It looks like this condition is failing in the tests
yingsu00
force-pushed
the
isBlockedTime
branch
3 times, most recently
from
7210e9f
to
b8705e6
Compare
For some operators, the isBlocked() function call is non-trivial. This commit adds the isBlockedTiming to OperatorStats and count it in Driver::runInternal(). It also count the isFinished() operator which was previously missed being counted.. Note that this does not include the Presto protocol change, which will be done later.
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in f4ca3c6. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.