Fmt folly update #10924
Closed
Fmt folly update #10924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a common file to download and install external dependencies. Extract versions for each library.
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
yingsu00
force-pushed
the
fmt_folly_update
branch
from
9026456
to
57073ff
Compare
Recently brew updated fmt version from 10.1 to 11.0. This caused build breaks. This commit contains 3 fixes: 1. Upgrade fmt to 11.0 from brew install. Remove the install_fmt call to avoid mismatching versions. 2. Error "'this' argument to member function 'format' has type 'const fmt::formatter<facebook::velox::exec::Spiller::Type>', but function is not marked const". The new fmt v11 forces the const check. To fix this error, the "const" keyword was added to the `format()` function declarations. 3. Error "error: static assertion failed due to requirement 'formattable_char': Mixing character types is disallowed." The new fmt v11 added a check if the arguments of fmt::make_format_args() have mixing different character types (e.g., char vs wchar_t or std::string vs folly::Range<const char*>). To fix this, we need to convert the folly::StringPiece to string. 4. Update folly to "v2024.08.26.00", this is needed because the previous version depends on fmt v10. To do this fast_float is added as one of MACOS_VELOX_DEPS. Note that if users see issues when building the new folly, they need to make sure the CMake cache is cleaned and clean the build directory first.
|
closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up the discussion in #10904
and depend on #10670