Ongoing clean up of DateTimeStampFunctionsTest.cpp #11050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D63067802 |
|
This pull request was exported from Phabricator. Differential Revision: D63067802 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Sep 20, 2024
…#11050) Summary: Pull Request resolved: facebookincubator#11050 Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed. Differential Revision: D63067802
DanielHunte
force-pushed
the
export-D63067802
branch
from
d510ca3
to
9f1eb24
Compare
…#11050) Summary: Pull Request resolved: facebookincubator#11050 Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed. Differential Revision: D63067802
|
This pull request was exported from Phabricator. Differential Revision: D63067802 |
DanielHunte
force-pushed
the
export-D63067802
branch
from
9f1eb24
to
f5878ac
Compare
|
This pull request has been merged in 8cd2d1a. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed.
Differential Revision: D63067802