-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ongoing clean up of DateTimeStampFunctionsTest.cpp #11050
Conversation
✅ Deploy Preview for meta-velox canceled.
|
This pull request was exported from Phabricator. Differential Revision: D63067802 |
This pull request was exported from Phabricator. Differential Revision: D63067802 |
…#11050) Summary: Pull Request resolved: facebookincubator#11050 Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed. Differential Revision: D63067802
d510ca3
to
9f1eb24
Compare
…#11050) Summary: Pull Request resolved: facebookincubator#11050 Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed. Differential Revision: D63067802
This pull request was exported from Phabricator. Differential Revision: D63067802 |
9f1eb24
to
f5878ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been merged in 8cd2d1a. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Summary: Velox functions now support the logical type TimeStampWithTimeZone. The use of "evaluateWithTimestampWithTimezone" is therefore no longer needed.
Differential Revision: D63067802