Add monthly update template #11195
Closed
Add monthly update template #11195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
force-pushed
the
monthly-document
branch
from
3b9b57b
to
01cc4ab
Compare
majetideepak
changed the title
majetideepak
force-pushed
the
monthly-document
branch
from
01cc4ab
to
3551c7e
Compare
kgpai
reviewed
Oct 16, 2024
velox/docs/README.md
Outdated
|
|
||
| Below are a few monthly update guidelines. | ||
| - Each update should be in the imperative, present tense similar to a git commit. | ||
| - In sections where applicable, start with the new additions with `Add` followed by |
There was a problem hiding this comment.
nit: Maybe also specify to, Start with 'Adds' followed by Fixes , followed by other .
majetideepak
force-pushed
the
monthly-document
branch
from
3551c7e
to
ac906c4
Compare
pedroerp
reviewed
Oct 19, 2024
| - In sections where applicable, start new additions with `Add` followed by | ||
| the fixes using `Fix`, followed by other updates. | ||
| - Group similar contributions together. Example: All Presto scalar functions can be | ||
| combined in one line. |
There was a problem hiding this comment.
Nice! Maybe we could add a pointer to where these files should be added, and/or a link to the directory?
|
@majetideepak is this still in draft mode? |
majetideepak
force-pushed
the
monthly-document
branch
from
88c93ad
to
b5763d2
Compare
|
@pedroerp I addressed your review comment. This is ready. |
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.