-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add monthly update template #11195
Add monthly update template #11195
Conversation
✅ Deploy Preview for meta-velox canceled.
|
3b9b57b
to
01cc4ab
Compare
01cc4ab
to
3551c7e
Compare
velox/docs/README.md
Outdated
|
||
Below are a few monthly update guidelines. | ||
- Each update should be in the imperative, present tense similar to a git commit. | ||
- In sections where applicable, start with the new additions with `Add` followed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe also specify to, Start with 'Adds' followed by Fixes , followed by other .
3551c7e
to
ac906c4
Compare
- In sections where applicable, start new additions with `Add` followed by | ||
the fixes using `Fix`, followed by other updates. | ||
- Group similar contributions together. Example: All Presto scalar functions can be | ||
combined in one line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Maybe we could add a pointer to where these files should be added, and/or a link to the directory?
@majetideepak is this still in draft mode? |
88c93ad
to
b5763d2
Compare
@pedroerp I addressed your review comment. This is ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @majetideepak
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
No description provided.